Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-15 Thread Alexey
On Wed, Jun 14, 2017 at 05:29:39PM +0200, Juan Quintela wrote: > Alexey Perevalov wrote: > > On 06/13/2017 02:42 PM, Juan Quintela wrote: > >> Alexey Perevalov wrote: > >> > >> Hi > >> > >> I think that it would make things clearer if we do a s/copied/received/ > >> As what we are tracking here a

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-14 Thread Juan Quintela
Alexey Perevalov wrote: > On 06/13/2017 02:42 PM, Juan Quintela wrote: >> Alexey Perevalov wrote: >> >> Hi >> >> I think that it would make things clearer if we do a s/copied/received/ >> As what we are tracking here are the pages that have already been >> received. >> >> >>> This patch adds abil

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-14 Thread Alexey Perevalov
On 06/13/2017 02:42 PM, Juan Quintela wrote: Alexey Perevalov wrote: Hi I think that it would make things clearer if we do a s/copied/received/ As what we are tracking here are the pages that have already been received. This patch adds ability to track down already copied pages, it's necess

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-14 Thread Alexey Perevalov
On 06/14/2017 09:53 AM, Peter Xu wrote: On Wed, Jun 14, 2017 at 09:39:53AM +0300, Alexey Perevalov wrote: On 06/14/2017 08:12 AM, Peter Xu wrote: On Tue, Jun 13, 2017 at 12:36:33PM +0300, Alexey Perevalov wrote: This patch adds ability to track down already copied pages, it's necessary for cal

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Peter Xu
On Wed, Jun 14, 2017 at 09:39:53AM +0300, Alexey Perevalov wrote: > On 06/14/2017 08:12 AM, Peter Xu wrote: > >On Tue, Jun 13, 2017 at 12:36:33PM +0300, Alexey Perevalov wrote: > >>This patch adds ability to track down already copied > >>pages, it's necessary for calculation vCPU block time in > >>

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Alexey Perevalov
On 06/14/2017 08:12 AM, Peter Xu wrote: On Tue, Jun 13, 2017 at 12:36:33PM +0300, Alexey Perevalov wrote: This patch adds ability to track down already copied pages, it's necessary for calculation vCPU block time in postcopy migration feature, maybe for restore after postcopy migration failure.

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Peter Xu
On Tue, Jun 13, 2017 at 12:36:33PM +0300, Alexey Perevalov wrote: > This patch adds ability to track down already copied > pages, it's necessary for calculation vCPU block time in > postcopy migration feature, maybe for restore after > postcopy migration failure. > Also it's necessary to solve shar

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Peter Xu
On Tue, Jun 13, 2017 at 03:00:28PM +0300, Alexey Perevalov wrote: > On 06/13/2017 02:42 PM, Juan Quintela wrote: [...] > >>Bitmap is placed into RAMBlock as another postcopy/precopy > >>related bitmaps. > >Why are we not using the TARGET_PAGE_SIZE as units of the bitmap? > Page size per ram block

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Alexey Perevalov
On 06/13/2017 02:42 PM, Juan Quintela wrote: Alexey Perevalov wrote: Hi I think that it would make things clearer if we do a s/copied/received/ As what we are tracking here are the pages that have already been received. yes, sounds good This patch adds ability to track down already copied

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Juan Quintela
Alexey Perevalov wrote: Hi I think that it would make things clearer if we do a s/copied/received/ As what we are tracking here are the pages that have already been received. > This patch adds ability to track down already copied > pages, it's necessary for calculation vCPU block time in > pos

[Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Alexey Perevalov
This patch adds ability to track down already copied pages, it's necessary for calculation vCPU block time in postcopy migration feature, maybe for restore after postcopy migration failure. Also it's necessary to solve shared memory issue in postcopy livemigration. Information about copied pages wi