Re: [Qemu-devel] [PATCH v1 1/3] sPAPR: Implement PCI error injection RTAS calls

2014-06-23 Thread Gavin Shan
On Mon, Jun 23, 2014 at 06:18:37PM +0200, Alexander Graf wrote: > >On 23.06.14 04:22, Gavin Shan wrote: >>The patch implements PCI error injection RTAS calls for sPAPR >>platform, which are defined PAPR spec as follows. Those RTAS >>calls are expected to be invoked in strict sequence of >>"ibm,open

Re: [Qemu-devel] [PATCH v1 1/3] sPAPR: Implement PCI error injection RTAS calls

2014-06-23 Thread Gavin Shan
On Mon, Jun 23, 2014 at 11:13:45PM +0200, Alexander Graf wrote: > >> Am 23.06.2014 um 23:03 schrieb Benjamin Herrenschmidt >> : >> >>> On Mon, 2014-06-23 at 18:18 +0200, Alexander Graf wrote: >>> Device emulation code shouldn't even remotely have an idea what host >>> it's running on. Also seman

Re: [Qemu-devel] [PATCH v1 1/3] sPAPR: Implement PCI error injection RTAS calls

2014-06-23 Thread Alexander Graf
> Am 23.06.2014 um 23:03 schrieb Benjamin Herrenschmidt > : > >> On Mon, 2014-06-23 at 18:18 +0200, Alexander Graf wrote: >> Device emulation code shouldn't even remotely have an idea what host >> it's running on. Also semantically there are a few issues with this approach >> >> 1) QEMU is

Re: [Qemu-devel] [PATCH v1 1/3] sPAPR: Implement PCI error injection RTAS calls

2014-06-23 Thread Benjamin Herrenschmidt
On Mon, 2014-06-23 at 18:18 +0200, Alexander Graf wrote: > Device emulation code shouldn't even remotely have an idea what host > it's running on. Also semantically there are a few issues with this approach > >1) QEMU is usually running with user privileges, so it doesn't have > access to th

Re: [Qemu-devel] [PATCH v1 1/3] sPAPR: Implement PCI error injection RTAS calls

2014-06-23 Thread Alexander Graf
On 23.06.14 04:22, Gavin Shan wrote: The patch implements PCI error injection RTAS calls for sPAPR platform, which are defined PAPR spec as follows. Those RTAS calls are expected to be invoked in strict sequence of "ibm,open-errinjct", "ibm,errinjct", "ibm,close-errinjct". - "ibm,open-errinjct"

[Qemu-devel] [PATCH v1 1/3] sPAPR: Implement PCI error injection RTAS calls

2014-06-22 Thread Gavin Shan
The patch implements PCI error injection RTAS calls for sPAPR platform, which are defined PAPR spec as follows. Those RTAS calls are expected to be invoked in strict sequence of "ibm,open-errinjct", "ibm,errinjct", "ibm,close-errinjct". - "ibm,open-errinjct": Apply for token to do error injection