Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-30 Thread Paolo Bonzini
Il 16/04/2014 19:20, Andreas Färber ha scritto: qdev paths used for VMState currently still depend on a bus, which Alex or Alexey wanted to look into fixing. By default -1 is supplied by DeviceState for registering dc->vmsd, which can be overridden by inlining the corresponding qdev.c code or mor

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-16 Thread Markus Armbruster
Andreas Färber writes: > Am 16.04.2014 08:42, schrieb Markus Armbruster: >> Peter Crosthwaite writes: >> >>> On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote: Am 15.04.2014 04:21, schrieb Peter Crosthwaite: > So clients can set the top level id string. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-16 Thread Peter Crosthwaite
On Thu, Apr 17, 2014 at 3:20 AM, Andreas Färber wrote: > Am 15.04.2014 23:39, schrieb Peter Crosthwaite: >> On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote: >>> Am 15.04.2014 04:21, schrieb Peter Crosthwaite: So clients can set the top level id string. Signed-off-by: Peter Cr

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-16 Thread Andreas Färber
Am 15.04.2014 23:39, schrieb Peter Crosthwaite: > On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote: >> Am 15.04.2014 04:21, schrieb Peter Crosthwaite: >>> So clients can set the top level id string. >>> >>> Signed-off-by: Peter Crosthwaite >> >> Anthony had nack'ed Paolo's attempt to general

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-16 Thread Andreas Färber
Am 16.04.2014 08:42, schrieb Markus Armbruster: > Peter Crosthwaite writes: > >> On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote: >>> Am 15.04.2014 04:21, schrieb Peter Crosthwaite: So clients can set the top level id string. Signed-off-by: Peter Crosthwaite >>> >>> Anthony

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-15 Thread Markus Armbruster
Peter Crosthwaite writes: > On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote: >> Am 15.04.2014 04:21, schrieb Peter Crosthwaite: >>> So clients can set the top level id string. >>> >>> Signed-off-by: Peter Crosthwaite >> >> Anthony had nack'ed Paolo's attempt to generalize the qdev id to Q

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-15 Thread Peter Crosthwaite
On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote: > Am 15.04.2014 04:21, schrieb Peter Crosthwaite: >> So clients can set the top level id string. >> >> Signed-off-by: Peter Crosthwaite > > Anthony had nack'ed Paolo's attempt to generalize the qdev id to QOM, so > I'm not sure if we should r

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-15 Thread Andreas Färber
Am 15.04.2014 04:21, schrieb Peter Crosthwaite: > So clients can set the top level id string. > > Signed-off-by: Peter Crosthwaite Anthony had nack'ed Paolo's attempt to generalize the qdev id to QOM, so I'm not sure if we should really do this even if just on device level. The id= is used to co

[Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-14 Thread Peter Crosthwaite
So clients can set the top level id string. Signed-off-by: Peter Crosthwaite --- hw/core/qdev.c | 13 +++-- include/hw/qdev-core.h | 2 +- qdev-monitor.c | 3 ++- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 60f9