Re: [Qemu-devel] [PATCH v1 1/2] target/arm: Add a cluster size property

2018-03-02 Thread Peter Maydell
On 2 March 2018 at 17:35, Alistair Francis wrote: > Ok will fix. I'll send a V2 out straight away, as today is my last day > and it'd be great if I could get this done. Sure -- if there are any further nits in v2 I'll just fix them up when I put it into target-arm.next. -- PMM

Re: [Qemu-devel] [PATCH v1 1/2] target/arm: Add a cluster size property

2018-03-02 Thread Alistair Francis
On Fri, Mar 2, 2018 at 9:31 AM, Peter Maydell wrote: > On 2 March 2018 at 17:06, Alistair Francis > wrote: > > Subject should say "core count" rather than "cluster size" ? Yes, that was left over. I'll fix. > >> The cortex A53 TRM specifices that bits 24 and 25 of the L2CTLR register > > "spec

Re: [Qemu-devel] [PATCH v1 1/2] target/arm: Add a cluster size property

2018-03-02 Thread Peter Maydell
On 2 March 2018 at 17:06, Alistair Francis wrote: Subject should say "core count" rather than "cluster size" ? > The cortex A53 TRM specifices that bits 24 and 25 of the L2CTLR register "specifies" > specify the number of cores present and not the number of processors. To "the number of cores

[Qemu-devel] [PATCH v1 1/2] target/arm: Add a cluster size property

2018-03-02 Thread Alistair Francis
The cortex A53 TRM specifices that bits 24 and 25 of the L2CTLR register specify the number of cores present and not the number of processors. To report this correctly on machines with multiple CPU clusters (ARM's big.LITTLE or Xilinx's ZynqMP) we need to allow the machine to overwrite this value.