Re: [Qemu-devel] [PATCH v1 1/2] io: send proper HTTP response for websocket errors

2017-09-07 Thread Daniel P. Berrange
On Wed, Sep 06, 2017 at 03:06:03PM -0300, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 09/06/2017 07:40 AM, Daniel P. Berrange wrote: > > When any error occurs while processing the websockets handshake, > > QEMU just terminates the connection abruptly. This is in violation > > of the HTTP spe

Re: [Qemu-devel] [PATCH v1 1/2] io: send proper HTTP response for websocket errors

2017-09-06 Thread Philippe Mathieu-Daudé
Hi Daniel, On 09/06/2017 07:40 AM, Daniel P. Berrange wrote: When any error occurs while processing the websockets handshake, QEMU just terminates the connection abruptly. This is in violation of the HTTP specs and does not help the client understand what they did wrong. This is particularly bad

[Qemu-devel] [PATCH v1 1/2] io: send proper HTTP response for websocket errors

2017-09-06 Thread Daniel P. Berrange
When any error occurs while processing the websockets handshake, QEMU just terminates the connection abruptly. This is in violation of the HTTP specs and does not help the client understand what they did wrong. This is particularly bad when the client gives the wrong path, as a "404 Not Found" woul