Re: [Qemu-devel] [PATCH v1 02/14] target-ppc: Add xxinsertw instruction

2017-01-06 Thread David Gibson
On Fri, Jan 06, 2017 at 01:58:19PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > [ Unknown signature status ] > > On Fri, Jan 06, 2017 at 11:44:44AM +0530, Nikunj A Dadhania wrote: > >> xxinsertw: VSX Vector Insert Word > >> > >> Signed-off-by: Nikunj A Dadhania > > > > The comme

Re: [Qemu-devel] [PATCH v1 02/14] target-ppc: Add xxinsertw instruction

2017-01-06 Thread David Gibson
On Fri, Jan 06, 2017 at 11:44:44AM +0530, Nikunj A Dadhania wrote: > xxinsertw: VSX Vector Insert Word > > Signed-off-by: Nikunj A Dadhania Applied to ppc-for-2.9. > --- > target/ppc/helper.h | 1 + > target/ppc/int_helper.c | 25 + > target

Re: [Qemu-devel] [PATCH v1 02/14] target-ppc: Add xxinsertw instruction

2017-01-06 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Fri, Jan 06, 2017 at 11:44:44AM +0530, Nikunj A Dadhania wrote: >> xxinsertw: VSX Vector Insert Word >> >> Signed-off-by: Nikunj A Dadhania > > The comments I had about out of bounds shifts don't seem to have been > addressed here. Bound

Re: [Qemu-devel] [PATCH v1 02/14] target-ppc: Add xxinsertw instruction

2017-01-06 Thread David Gibson
On Fri, Jan 06, 2017 at 11:44:44AM +0530, Nikunj A Dadhania wrote: > xxinsertw: VSX Vector Insert Word > > Signed-off-by: Nikunj A Dadhania The comments I had about out of bounds shifts don't seem to have been addressed here. > --- > target/ppc/helper.h | 1 + > target/ppc/int

[Qemu-devel] [PATCH v1 02/14] target-ppc: Add xxinsertw instruction

2017-01-05 Thread Nikunj A Dadhania
xxinsertw: VSX Vector Insert Word Signed-off-by: Nikunj A Dadhania --- target/ppc/helper.h | 1 + target/ppc/int_helper.c | 25 + target/ppc/translate/vsx-impl.inc.c | 5 +++-- target/ppc/translate/vsx-ops.inc.c | 1 + 4 files changed, 30 i