Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-19 Thread Michael S. Tsirkin
On Mon, Jun 16, 2014 at 01:29:08PM -0400, Gabriel L. Somlo wrote: > This series contains a few fixes and improvements in the emulation > of link auto-negotiation: > > - use auto-negotiation when the link is bounced externally (e.g. via > set_link down/up on the qemu monitor command line). >

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-18 Thread Stefan Hajnoczi
On Mon, Jun 16, 2014 at 01:29:08PM -0400, Gabriel L. Somlo wrote: > This series contains a few fixes and improvements in the emulation > of link auto-negotiation: > > - use auto-negotiation when the link is bounced externally (e.g. via > set_link down/up on the qemu monitor command line). >

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-17 Thread Alexander Graf
On 17.06.14 12:48, Michael S. Tsirkin wrote: On Tue, Jun 17, 2014 at 08:33:00AM +0200, Alexander Graf wrote: Am 17.06.2014 um 06:31 schrieb Paolo Bonzini : Il 17/06/2014 00:35, Alexander Graf ha scritto: On 16.06.14 19:29, Gabriel L. Somlo wrote: This series contains a few fixes and improve

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-17 Thread Michael S. Tsirkin
On Tue, Jun 17, 2014 at 08:33:00AM +0200, Alexander Graf wrote: > > > > Am 17.06.2014 um 06:31 schrieb Paolo Bonzini : > > > > Il 17/06/2014 00:35, Alexander Graf ha scritto: > >> > >>> On 16.06.14 19:29, Gabriel L. Somlo wrote: > >>> This series contains a few fixes and improvements in the emu

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-17 Thread Paolo Bonzini
Il 17/06/2014 08:33, Alexander Graf ha scritto: >> Looks very reasonable and straight forward to me. >> >> Reviewed-by: Alexander Graf > > Would you pick it up and send a pull request for it? Is e1000 / networking unmaintained? Doh, it's obviously Stefan's area. Paolo

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-16 Thread Alexander Graf
> Am 17.06.2014 um 06:31 schrieb Paolo Bonzini : > > Il 17/06/2014 00:35, Alexander Graf ha scritto: >> >>> On 16.06.14 19:29, Gabriel L. Somlo wrote: >>> This series contains a few fixes and improvements in the emulation >>> of link auto-negotiation: >>> >>> - use auto-negotiation when the

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-16 Thread Paolo Bonzini
Il 17/06/2014 00:35, Alexander Graf ha scritto: On 16.06.14 19:29, Gabriel L. Somlo wrote: This series contains a few fixes and improvements in the emulation of link auto-negotiation: - use auto-negotiation when the link is bounced externally (e.g. via set_link down/up on the qemu mon

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-16 Thread Alexander Graf
On 16.06.14 19:29, Gabriel L. Somlo wrote: This series contains a few fixes and improvements in the emulation of link auto-negotiation: - use auto-negotiation when the link is bounced externally (e.g. via set_link down/up on the qemu monitor command line). - allow mii_tool on linux

[Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-16 Thread Gabriel L. Somlo
This series contains a few fixes and improvements in the emulation of link auto-negotiation: - use auto-negotiation when the link is bounced externally (e.g. via set_link down/up on the qemu monitor command line). - allow mii_tool on linux access to all the phy registers and flags it