Re: [Qemu-devel] [PATCH v1] vl: Fix possible freed memory accessing

2014-09-19 Thread Peter Maydell
On 18 September 2014 23:54, Markus Armbruster wrote: > I think we should remove the whole thing: pcmcia_sockets, > pcmcia_socket_register(), pcmcia_socket_unregister, pcmcia_info(). > Here's why. > > It serves just one purpose: "info pcmcia". HMP-only, therefore not a > stable interface. But is

Re: [Qemu-devel] [PATCH v1] vl: Fix possible freed memory accessing

2014-09-19 Thread Paolo Bonzini
Il 19/09/2014 05:37, zhanghailiang ha scritto: > The logic of pcmcia_socket_unregister is wrong, > which will cause a freed memory accessing > > Signed-off-by: zhanghailiang > --- > Hi, > > The function pcmcia_socket_unregister seemes to be unused, > Should it be removed? Thanks. Perhaps---howe

Re: [Qemu-devel] [PATCH v1] vl: Fix possible freed memory accessing

2014-09-19 Thread Markus Armbruster
zhanghailiang writes: > The logic of pcmcia_socket_unregister is wrong, > which will cause a freed memory accessing > > Signed-off-by: zhanghailiang > --- > Hi, > > The function pcmcia_socket_unregister seemes to be unused, > Should it be removed? Thanks. I think we should remove the whole thin

[Qemu-devel] [PATCH v1] vl: Fix possible freed memory accessing

2014-09-18 Thread zhanghailiang
The logic of pcmcia_socket_unregister is wrong, which will cause a freed memory accessing Signed-off-by: zhanghailiang --- Hi, The function pcmcia_socket_unregister seemes to be unused, Should it be removed? Thanks. --- vl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a