Re: [Qemu-devel] [PATCH v1] virtio-net: code cleanup

2017-07-03 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 01:53:20PM +0800, Wei Wang wrote: > Use is_power_of_2(), and remove trailing "." from error_setg(). > > Signed-off-by: Wei Wang Reviewed-by: Michael S. Tsirkin > --- > hw/net/virtio-net.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/h

Re: [Qemu-devel] [PATCH v1] virtio-net: code cleanup

2017-06-28 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 08:02:06AM -0500, Eric Blake wrote: > [meta-comment, replacing virtio-dev with virtio-dev-owner in cc] > > On 06/28/2017 07:22 AM, Eric Blake wrote: > > On 06/28/2017 12:53 AM, Wei Wang wrote: > >> Use is_power_of_2(), and remove trailing "." from error_setg(). > >> > >> Si

Re: [Qemu-devel] [PATCH v1] virtio-net: code cleanup

2017-06-28 Thread Eric Blake
[meta-comment, replacing virtio-dev with virtio-dev-owner in cc] On 06/28/2017 07:22 AM, Eric Blake wrote: > On 06/28/2017 12:53 AM, Wei Wang wrote: >> Use is_power_of_2(), and remove trailing "." from error_setg(). >> >> Signed-off-by: Wei Wang >> --- >> hw/net/virtio-net.c | 6 +++--- >> 1 fil

Re: [Qemu-devel] [PATCH v1] virtio-net: code cleanup

2017-06-28 Thread Eric Blake
On 06/28/2017 12:53 AM, Wei Wang wrote: > Use is_power_of_2(), and remove trailing "." from error_setg(). > > Signed-off-by: Wei Wang > --- > hw/net/virtio-net.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer R

[Qemu-devel] [PATCH v1] virtio-net: code cleanup

2017-06-27 Thread Wei Wang
Use is_power_of_2(), and remove trailing "." from error_setg(). Signed-off-by: Wei Wang --- hw/net/virtio-net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 91eddaf..144169c 100644 --- a/hw/net/virtio-net.c +++ b/hw/net