Re: [Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating problems with pflash

2017-09-21 Thread Paolo Bonzini
On 21/09/2017 08:49, Gerd Hoffmann wrote: > On Wed, 2017-09-20 at 16:50 +0200, David Hildenbrand wrote: >> pflash toggles mr->romd_mode. So this assert does not always hold. >> >> 1) a device was added with !mr->romd_mode, therefore effectively not >>    creating a kvm slot as we want to trap every

Re: [Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating problems with pflash

2017-09-20 Thread Gerd Hoffmann
On Wed, 2017-09-20 at 16:50 +0200, David Hildenbrand wrote: > pflash toggles mr->romd_mode. So this assert does not always hold. > > 1) a device was added with !mr->romd_mode, therefore effectively not >    creating a kvm slot as we want to trap every access (add = false). > 2) mr->romd_mode was t

[Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating problems with pflash

2017-09-20 Thread David Hildenbrand
pflash toggles mr->romd_mode. So this assert does not always hold. 1) a device was added with !mr->romd_mode, therefore effectively not creating a kvm slot as we want to trap every access (add = false). 2) mr->romd_mode was toggled on before remove it. There is now actually no slot to remove