Re: [Qemu-devel] [PATCH v1] hw: fix error reporting for missing option ROMs

2016-03-11 Thread Daniel P. Berrange
On Thu, Mar 10, 2016 at 01:25:08PM -0700, Eric Blake wrote: > On 03/10/2016 10:28 AM, Daniel P. Berrange wrote: > > If QEMU fails to load any of the VGA ROMs, it prints a message > > to stderr and then carries on as if everything was fine, despite > > the VGA interface not being functional. This ex

Re: [Qemu-devel] [PATCH v1] hw: fix error reporting for missing option ROMs

2016-03-10 Thread Eric Blake
On 03/10/2016 10:28 AM, Daniel P. Berrange wrote: > If QEMU fails to load any of the VGA ROMs, it prints a message > to stderr and then carries on as if everything was fine, despite > the VGA interface not being functional. This extends the the > rom_add_file() method to accept a 'Error **errp' par

[Qemu-devel] [PATCH v1] hw: fix error reporting for missing option ROMs

2016-03-10 Thread Daniel P. Berrange
If QEMU fails to load any of the VGA ROMs, it prints a message to stderr and then carries on as if everything was fine, despite the VGA interface not being functional. This extends the the rom_add_file() method to accept a 'Error **errp' parameter. The VGA device realizefn() impls can now pass in t