Re: [Qemu-devel] [PATCH v1] highbank: validate register offset before access

2017-11-13 Thread P J P
Hello Philippe, +-- On Sun, 12 Nov 2017, Philippe Mathieu-Daudé wrote --+ | I'd rather use: | |"highbank: bad write offset 0x%" HWADDR_PRIx "\n", offset); Sent revised patch v2. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE

Re: [Qemu-devel] [PATCH v1] highbank: validate register offset before access

2017-11-12 Thread Philippe Mathieu-Daudé
Hi Prasad, Thanks for updating this patch so quickly :) On 11/11/2017 05:11 AM, P J P wrote: > From: Prasad J Pandit > > An 'offset' parameter sent to highbank register r/w functions > could be greater than number(NUM_REGS=0x200) of hb registers, > leading to an OOB access issue. Add check to a

Re: [Qemu-devel] [PATCH v1] highbank: validate register offset before access

2017-11-11 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v1] highbank: validate register offset before access Type: series Message-id: 201708.32724-1-ppan...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCH v1] highbank: validate register offset before access

2017-11-11 Thread P J P
From: Prasad J Pandit An 'offset' parameter sent to highbank register r/w functions could be greater than number(NUM_REGS=0x200) of hb registers, leading to an OOB access issue. Add check to avoid it. Reported-by: Moguofang (Dennis mo) Signed-off-by: Prasad J Pandit --- hw/arm/highbank.c | 15