Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180809141403.11296-1-o...@aepfle.de
Subject: [Qemu-devel] [PATCH v1] exec: handle NULL pointer in
flatview_read_continue
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
On 13/08/2018 22:07, Olaf Hering wrote:
> Since other callers already deal with NULL, that one has to cope as well.
They don't.
- address_space_map just returns the value that qemu_ram_ptr_length
returned, and none of its callers deal with NULL (there are dozens)
- likewise for address_space_cac
Am Fri, 10 Aug 2018 14:29:28 +0200
schrieb Paolo Bonzini :
> On 10/08/2018 12:32, Olaf Hering wrote:
> > Am Fri, 10 Aug 2018 12:25:09 +0200
> > schrieb Paolo Bonzini :
> > So you mean that function must not return NULL?
> > Or should the caller check for the result?
> Either, but the former woul
On 10/08/2018 12:32, Olaf Hering wrote:
> Am Fri, 10 Aug 2018 12:25:09 +0200
> schrieb Paolo Bonzini :
>
>> There are many more callers of qemu_ram_ptr_length, and none of them check
>> the result.
>
> So you mean that function must not return NULL?
> Or should the caller check for the result?
Am Fri, 10 Aug 2018 12:25:09 +0200
schrieb Paolo Bonzini :
> There are many more callers of qemu_ram_ptr_length, and none of them check
> the result.
So you mean that function must not return NULL?
Or should the caller check for the result?
Olaf
pgp6zq9J9aL36.pgp
Description: Digitale Signatu
On 09/08/2018 17:03, Paolo Bonzini wrote:
> On 09/08/2018 16:55, Olaf Hering wrote:
>>
>>> I think the simplest fix is for the map
>>> cache to set aside a zero page and return it whenever it is asked for a
>>> ballooned page.
>> Can qemu actually know if it ran into a ballooned page? I think no.
>
On 09/08/2018 16:55, Olaf Hering wrote:
>
>> I think the simplest fix is for the map
>> cache to set aside a zero page and return it whenever it is asked for a
>> ballooned page.
> Can qemu actually know if it ran into a ballooned page? I think no.
Well, xen_map_cache knows that it has run into *
Am Thu, 9 Aug 2018 16:52:22 +0200
schrieb Paolo Bonzini :
> I think the simplest fix is for the map
> cache to set aside a zero page and return it whenever it is asked for a
> ballooned page.
Can qemu actually know if it ran into a ballooned page? I think no.
Olaf
pgpmdqCLn4Xnn.pgp
Description
Am Thu, 9 Aug 2018 16:38:16 +0200
schrieb Olaf Hering :
> Someone familiar with that code has to figure that out. A ballooned page will
> trigger that bug.
Indeed, xen-4.4 + qemu-3.0 crashes with ballooned pages. That can easily happen
if the domU does readdir via NFS.
Olaf
Thread 1 "qemu-sys
On 09/08/2018 16:38, Olaf Hering wrote:
> Am Thu, 9 Aug 2018 16:37:05 +0200
> schrieb Paolo Bonzini :
>
>> If no RAM is allocated (i.e. xen_map_cache will return NULL), however,
>> the memory should not be registered as RAM with the memory API. So I
>> think the bug is in Xen code.
>
> Someone f
Am Thu, 9 Aug 2018 16:37:05 +0200
schrieb Paolo Bonzini :
> If no RAM is allocated (i.e. xen_map_cache will return NULL), however,
> the memory should not be registered as RAM with the memory API. So I
> think the bug is in Xen code.
Someone familiar with that code has to figure that out. A ball
On 09/08/2018 16:24, Olaf Hering wrote:
> Am Thu, 9 Aug 2018 16:14:03 +0200 schrieb Olaf Hering
> :
>
>> The codepaths behind qemu_ram_ptr_length can return NULL.
>
> While that might be a bug by itself, the question is why in that case
> no memset(buf, 0xff, l) is done?
If no RAM is allocated (
Am Thu, 9 Aug 2018 16:14:03 +0200
schrieb Olaf Hering :
> The codepaths behind qemu_ram_ptr_length can return NULL.
While that might be a bug by itself, the question is why in that case no
memset(buf, 0xff, l) is done?
Olaf
pgpPcpqmT0hnz.pgp
Description: Digitale Signatur von OpenPGP
The codepaths behind qemu_ram_ptr_length can return NULL.
Avoid crashing the device-model in such case, just move on.
Signed-off-by: Olaf Hering
---
This happens if calling xendevicemodel_create_ioreq_server() is disabled,
and eventually if that function returns an error.
---
exec.c | 3 ++-
1 f
14 matches
Mail list logo
