On Sun, Apr 19, 2015 at 8:21 PM, Andreas Färber wrote:
> Hi,
>
> Am 19.04.2015 um 18:38 schrieb Itamar Tal:
> > I've set it just after the subject field in the patch? Should I add it
> > somewhere else and resubmit?
>
> Please compare other QEMU or Linux patches: It needs to go before ---
> into
On 19 April 2015 at 11:52, wrote:
> From: Itamar Tal
>
> ---
> default-configs/i386-softmmu.mak |1 +
> default-configs/x86_64-softmmu.mak |1 +
> hw/1394/Makefile.objs |1 +
> hw/1394/hcd-ohci.c | 1754
>
> hw/139
Hi,
Am 19.04.2015 um 18:38 schrieb Itamar Tal:
> I've set it just after the subject field in the patch? Should I add it
> somewhere else and resubmit?
Please compare other QEMU or Linux patches: It needs to go before ---
into the commit message. git commit --amend -s will place it correctly.
BTW
I've set it just after the subject field in the patch? Should I add it
somewhere else and resubmit?
On Apr 19, 2015 6:47 PM, "Andreas Färber" wrote:
> Am 19.04.2015 um 12:52 schrieb itamar.t...@gmail.com:
> > From: Itamar Tal
> >
> > ---
>
> Still no Signed-off-by...
>
> Regards,
> Andreas
>
> -
Am 19.04.2015 um 12:52 schrieb itamar.t...@gmail.com:
> From: Itamar Tal
>
> ---
Still no Signed-off-by...
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
From: Itamar Tal
---
default-configs/i386-softmmu.mak |1 +
default-configs/x86_64-softmmu.mak |1 +
hw/1394/Makefile.objs |1 +
hw/1394/hcd-ohci.c | 1754
hw/1394/hcd-ohci.h | 147 +++
hw/Makefile.o
