Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

2014-04-01 Thread Chen Gang
On 04/01/2014 09:33 PM, Markus Armbruster wrote: > Chen Gang writes: > >> On 04/01/2014 04:13 PM, Markus Armbruster wrote: >>> Chen Gang writes: >>> On 03/31/2014 11:49 PM, Markus Armbruster wrote: > Chen Gang writes: > >> in get_boot_device() >> >> - remove 'res' to s

Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

2014-04-01 Thread Markus Armbruster
Chen Gang writes: > On 04/01/2014 04:13 PM, Markus Armbruster wrote: >> Chen Gang writes: >> >>> On 03/31/2014 11:49 PM, Markus Armbruster wrote: Chen Gang writes: > in get_boot_device() > > - remove 'res' to simplify code > > in main(): > > - remove use

Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

2014-04-01 Thread Chen Gang
On 04/01/2014 08:36 PM, Alex Bennée wrote: > > Chen Gang writes: > >> Hello Maintainers: >> >> In main switch of main(), it contents several styles for "{...}" code block. >> >> If it is necessary to use unique style within a function, please let me >> know, I will/should clean up it. And also b

Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

2014-04-01 Thread Alex Bennée
Chen Gang writes: > Hello Maintainers: > > In main switch of main(), it contents several styles for "{...}" code block. > > If it is necessary to use unique style within a function, please let me > know, I will/should clean up it. And also better to tell me which style > we need choose -- for me

Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

2014-04-01 Thread Chen Gang
On 04/01/2014 04:13 PM, Markus Armbruster wrote: > Chen Gang writes: > >> On 03/31/2014 11:49 PM, Markus Armbruster wrote: >>> Chen Gang writes: >>> in get_boot_device() - remove 'res' to simplify code in main(): - remove useless 'continue'. - in m

Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

2014-04-01 Thread Markus Armbruster
Chen Gang writes: > On 03/31/2014 11:49 PM, Markus Armbruster wrote: >> Chen Gang writes: >> >>> in get_boot_device() >>> >>> - remove 'res' to simplify code >>> >>> in main(): >>> >>> - remove useless 'continue'. >>> >>> - in main switch(): >>> >>>- remove or adjust all useless 'break'.

Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

2014-03-31 Thread Chen Gang
On 03/31/2014 11:49 PM, Markus Armbruster wrote: > Chen Gang writes: > >> in get_boot_device() >> >> - remove 'res' to simplify code >> >> in main(): >> >> - remove useless 'continue'. >> >> - in main switch(): >> >>- remove or adjust all useless 'break'. >> >>- remove useless '{' and

Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

2014-03-31 Thread Markus Armbruster
Chen Gang writes: > in get_boot_device() > > - remove 'res' to simplify code > > in main(): > > - remove useless 'continue'. > > - in main switch(): > >- remove or adjust all useless 'break'. > >- remove useless '{' and '}'. > > - use assignment directly to replace useless 'args' >

Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

2014-03-30 Thread Chen Gang
Hello Maintainers: In main switch of main(), it contents several styles for "{...}" code block. If it is necessary to use unique style within a function, please let me know, I will/should clean up it. And also better to tell me which style we need choose -- for me, I don't know which style is the

[Qemu-devel] [PATCH trival] vl.c: clean up code

2014-03-30 Thread Chen Gang
in get_boot_device() - remove 'res' to simplify code in main(): - remove useless 'continue'. - in main switch(): - remove or adjust all useless 'break'. - remove useless '{' and '}'. - use assignment directly to replace useless 'args' (which is defined in the middle of code bloc