Re: [Qemu-devel] [PATCH target-arm v1 6/9] target-arm: Implement PMSAv7 MPU

2015-06-10 Thread Peter Crosthwaite
On Wed, Jun 10, 2015 at 3:21 PM, Peter Maydell wrote: > On 10 June 2015 at 23:17, Peter Crosthwaite > wrote: >> On Tue, Jun 2, 2015 at 4:59 AM, Peter Maydell >> wrote: >>> On 1 June 2015 at 19:04, Peter Crosthwaite >>> wrote: +switch (access_type) { +case 0: +re

Re: [Qemu-devel] [PATCH target-arm v1 6/9] target-arm: Implement PMSAv7 MPU

2015-06-10 Thread Peter Maydell
On 10 June 2015 at 23:17, Peter Crosthwaite wrote: > On Tue, Jun 2, 2015 at 4:59 AM, Peter Maydell > wrote: >> On 1 June 2015 at 19:04, Peter Crosthwaite >> wrote: >>> +switch (access_type) { >>> +case 0: >>> +return *prot & PAGE_READ ? 0 : 0x00D; >>> +case 1: >>> +

Re: [Qemu-devel] [PATCH target-arm v1 6/9] target-arm: Implement PMSAv7 MPU

2015-06-10 Thread Peter Crosthwaite
On Tue, Jun 2, 2015 at 4:59 AM, Peter Maydell wrote: > On 1 June 2015 at 19:04, Peter Crosthwaite > wrote: >> Unified MPU only. Uses ARM architecture major revision to switch >> between PMSAv5 and v7 when ARM_FEATURE_MPU is set. PMSA v6 remains >> unsupported and is asserted against. >> >> The r

Re: [Qemu-devel] [PATCH target-arm v1 6/9] target-arm: Implement PMSAv7 MPU

2015-06-02 Thread Peter Maydell
On 1 June 2015 at 19:04, Peter Crosthwaite wrote: > Unified MPU only. Uses ARM architecture major revision to switch > between PMSAv5 and v7 when ARM_FEATURE_MPU is set. PMSA v6 remains > unsupported and is asserted against. > > The return code from get_phys_addr has to patched to handle the case

[Qemu-devel] [PATCH target-arm v1 6/9] target-arm: Implement PMSAv7 MPU

2015-06-01 Thread Peter Crosthwaite
Unified MPU only. Uses ARM architecture major revision to switch between PMSAv5 and v7 when ARM_FEATURE_MPU is set. PMSA v6 remains unsupported and is asserted against. The return code from get_phys_addr has to patched to handle the case of a 0 FSR with error. Use -1 to indicate this condition. S