Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-11 Thread Andreas Färber
Am 11.06.2012 23:48, schrieb Anthony Liguori: > On 06/11/2012 04:31 PM, Andreas Färber wrote: >> Am 11.06.2012 15:21, schrieb Anthony Liguori: >>> On 06/11/2012 03:25 AM, Kevin Wolf wrote: Am 10.06.2012 19:38, schrieb Andreas Färber: > Am 10.06.2012 17:49, schrieb Paolo Bonzini: >> Il

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-11 Thread Anthony Liguori
On 06/11/2012 04:31 PM, Andreas Färber wrote: Am 11.06.2012 15:21, schrieb Anthony Liguori: On 06/11/2012 03:25 AM, Kevin Wolf wrote: Am 10.06.2012 19:38, schrieb Andreas Färber: Am 10.06.2012 17:49, schrieb Paolo Bonzini: Il 08/06/2012 03:19, Anthony Liguori ha scritto: +typedef enum Objec

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-11 Thread Andreas Färber
Am 11.06.2012 23:31, schrieb Andreas Färber: > Am 11.06.2012 15:21, schrieb Anthony Liguori: >> On 06/11/2012 03:25 AM, Kevin Wolf wrote: >>> Am 10.06.2012 19:38, schrieb Andreas Färber: Am 10.06.2012 17:49, schrieb Paolo Bonzini: > Il 08/06/2012 03:19, Anthony Liguori ha scritto: >>>

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-11 Thread Andreas Färber
Am 11.06.2012 15:21, schrieb Anthony Liguori: > On 06/11/2012 03:25 AM, Kevin Wolf wrote: >> Am 10.06.2012 19:38, schrieb Andreas Färber: >>> Am 10.06.2012 17:49, schrieb Paolo Bonzini: Il 08/06/2012 03:19, Anthony Liguori ha scritto: >> >> +typedef enum ObjectState { >> +OBJEC

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-11 Thread Kevin Wolf
Am 11.06.2012 15:21, schrieb Anthony Liguori: > On 06/11/2012 03:25 AM, Kevin Wolf wrote: >> Am 10.06.2012 19:38, schrieb Andreas Färber: >>> Am 10.06.2012 17:49, schrieb Paolo Bonzini: Il 08/06/2012 03:19, Anthony Liguori ha scritto: >> >> +typedef enum ObjectState { >> +OBJEC

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-11 Thread Anthony Liguori
On 06/11/2012 03:25 AM, Kevin Wolf wrote: Am 10.06.2012 19:38, schrieb Andreas Färber: Am 10.06.2012 17:49, schrieb Paolo Bonzini: Il 08/06/2012 03:19, Anthony Liguori ha scritto: +typedef enum ObjectState { +OBJECT_STATE_INITIALIZED = 1, +OBJECT_STATE_REALIZED, +} ObjectState; I th

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-11 Thread Kevin Wolf
Am 10.06.2012 19:38, schrieb Andreas Färber: > Am 10.06.2012 17:49, schrieb Paolo Bonzini: >> Il 08/06/2012 03:19, Anthony Liguori ha scritto: +typedef enum ObjectState { +OBJECT_STATE_INITIALIZED = 1, +OBJECT_STATE_REALIZED, +} ObjectState; >>> >>> I think using a

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-10 Thread Andreas Färber
Am 10.06.2012 17:49, schrieb Paolo Bonzini: > Il 08/06/2012 03:19, Anthony Liguori ha scritto: >>> >>> +typedef enum ObjectState { >>> +OBJECT_STATE_INITIALIZED = 1, >>> +OBJECT_STATE_REALIZED, >>> +} ObjectState; >> >> I think using a bool would be better since it reduces the temptation to

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-10 Thread Anthony Liguori
On 06/10/2012 10:49 AM, Paolo Bonzini wrote: Il 08/06/2012 03:19, Anthony Liguori ha scritto: +typedef enum ObjectState { +OBJECT_STATE_INITIALIZED = 1, +OBJECT_STATE_REALIZED, +} ObjectState; I think using a bool would be better since it reduces the temptation to add additional state

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-10 Thread Paolo Bonzini
Il 08/06/2012 03:19, Anthony Liguori ha scritto: >> >> +typedef enum ObjectState { >> +OBJECT_STATE_INITIALIZED = 1, >> +OBJECT_STATE_REALIZED, >> +} ObjectState; > > I think using a bool would be better since it reduces the temptation to > add additional states. In fact someone already d

Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-07 Thread Anthony Liguori
On 06/08/2012 03:30 AM, Andreas Färber wrote: From: Paolo Bonzini qdev properties use the state member (an embryo of the "realized" property) in order to disable setting them after a device has been initialized. So, in order to push qdev properties up to Object we need to push this bit there to

[Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object

2012-06-07 Thread Andreas Färber
From: Paolo Bonzini qdev properties use the state member (an embryo of the "realized" property) in order to disable setting them after a device has been initialized. So, in order to push qdev properties up to Object we need to push this bit there too. Signed-off-by: Paolo Bonzini [AF: Rename t