Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest

2014-02-08 Thread Stefan Hajnoczi
On Fri, Feb 07, 2014 at 07:06:58PM +0100, Andreas Färber wrote: > Am 07.02.2014 16:48, schrieb Stefan Hajnoczi: > > On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas Färber wrote: > >> +#include "libqtest.h" > >> + > >> +#include > >> +#include > >> +#include "qemu/osdep.h" > > > > Please put i

Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest

2014-02-07 Thread Andreas Färber
Am 07.02.2014 16:48, schrieb Stefan Hajnoczi: > On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas Färber wrote: >> +#include "libqtest.h" >> + >> +#include >> +#include >> +#include "qemu/osdep.h" > > Please put includes before "user.h" includes. That way we > can be sure our macros don't mess

Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest

2014-02-07 Thread Stefan Hajnoczi
On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas Färber wrote: > +#include "libqtest.h" > + > +#include > +#include > +#include "qemu/osdep.h" Please put includes before "user.h" includes. That way we can be sure our macros don't mess up system headers. > + > +static void nop(void) > +{ > +}

[Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest

2014-02-05 Thread Andreas Färber
Cc: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 7 +++ tests/e1000-test.c | 35 +++ 2 files changed, 42 insertions(+) create mode 100644 tests/e1000-test.c diff --git a/tests/Makefile b/tests/Makefile index 42a52ff..57e21fc 100644