On 03/05/2017 03:25, Alexey Kardashevskiy wrote:
>>
>> I find "iommumr" terribly hard to read. Maybe iommu_mr is better? (Lots
>> of times in this patch.)
>>
> Terribly? Really? :) Seriously, since linux uses underscores in typenames,
> I kind of developed resistance to underscores in variable
On Tue, May 02, 2017 at 06:25:50PM +0200, Cornelia Huck wrote:
> On Sat, 29 Apr 2017 22:37:07 +1000
> Alexey Kardashevskiy wrote:
>
> > This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion
> > as a parent.
> >
> > This moves IOMMU-related fields from MR to IOMMU MR. However to avo
On 03/05/17 02:25, Cornelia Huck wrote:
> On Sat, 29 Apr 2017 22:37:07 +1000
> Alexey Kardashevskiy wrote:
>
>> This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion
>> as a parent.
>>
>> This moves IOMMU-related fields from MR to IOMMU MR. However to avoid
>> dymanic QOM casting in
On Sat, 29 Apr 2017 22:37:07 +1000
Alexey Kardashevskiy wrote:
> This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion
> as a parent.
>
> This moves IOMMU-related fields from MR to IOMMU MR. However to avoid
> dymanic QOM casting in fast path (address_space_translate, etc),
> this
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH qemu v5] memory/iommu: QOM'fy IOMMU MemoryRegion
Message-id: 20170429123707.16675-1-...@ozlabs.ru
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion
as a parent.
This moves IOMMU-related fields from MR to IOMMU MR. However to avoid
dymanic QOM casting in fast path (address_space_translate, etc),
this adds an @is_iommu boolean flag to MR and provides new helper to
do simple cas
