Re: [Qemu-devel] [PATCH qemu] e1000: CTRL.RST emulation

2011-09-27 Thread Anthony Liguori
On 09/27/2011 06:50 AM, Peter Maydell wrote: On 27 September 2011 12:25, Michael S. Tsirkin wrote: e1000 spec says CTRL.RST write should have the same effect as bus reset, except that is preserves PCI Config. Reset device registers and interrupts. Fix suggested by Andy Gospodarek Doesn't thi

Re: [Qemu-devel] [PATCH qemu] e1000: CTRL.RST emulation

2011-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2011 at 01:39:17PM +0100, Peter Maydell wrote: > On 27 September 2011 13:32, Michael S. Tsirkin wrote: > > On Tue, Sep 27, 2011 at 12:50:21PM +0100, Peter Maydell wrote: > >> On 27 September 2011 12:25, Michael S. Tsirkin wrote: > >> > e1000 spec says CTRL.RST write should have th

Re: [Qemu-devel] [PATCH qemu] e1000: CTRL.RST emulation

2011-09-27 Thread Peter Maydell
On 27 September 2011 13:32, Michael S. Tsirkin wrote: > On Tue, Sep 27, 2011 at 12:50:21PM +0100, Peter Maydell wrote: >> On 27 September 2011 12:25, Michael S. Tsirkin wrote: >> > e1000 spec says CTRL.RST write should have the same effect >> > as bus reset, except that is preserves PCI Config. >

Re: [Qemu-devel] [PATCH qemu] e1000: CTRL.RST emulation

2011-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2011 at 12:50:21PM +0100, Peter Maydell wrote: > On 27 September 2011 12:25, Michael S. Tsirkin wrote: > > e1000 spec says CTRL.RST write should have the same effect > > as bus reset, except that is preserves PCI Config. > > Reset device registers and interrupts. > > > > Fix sugges

Re: [Qemu-devel] [PATCH qemu] e1000: CTRL.RST emulation

2011-09-27 Thread Peter Maydell
On 27 September 2011 12:25, Michael S. Tsirkin wrote: > e1000 spec says CTRL.RST write should have the same effect > as bus reset, except that is preserves PCI Config. > Reset device registers and interrupts. > > Fix suggested by Andy Gospodarek Doesn't this have the same effect as this patch: h

[Qemu-devel] [PATCH qemu] e1000: CTRL.RST emulation

2011-09-27 Thread Michael S. Tsirkin
e1000 spec says CTRL.RST write should have the same effect as bus reset, except that is preserves PCI Config. Reset device registers and interrupts. Fix suggested by Andy Gospodarek Signed-off-by: Michael S. Tsirkin --- hw/e1000.c | 97 +++-