Re: [Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees

2019-02-28 Thread Peter Maydell
On Thu, 28 Feb 2019 at 04:36, Alexey Kardashevskiy wrote: > > The configure script checks multiple times whether it works in a git > repository and it does this by "test -e "${source_path}/.git" in 4 cases > but in one case where it tries to enable werror "-d" is used there which > fails on git wo

Re: [Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees

2019-02-28 Thread Paolo Bonzini
On 28/02/19 08:14, Gerd Hoffmann wrote: > On Thu, Feb 28, 2019 at 08:01:53AM +0100, Thomas Huth wrote: >> On 28/02/2019 06.00, David Gibson wrote: >>> On Thu, Feb 28, 2019 at 03:35:03PM +1100, Alexey Kardashevskiy wrote: The configure script checks multiple times whether it works in a git

Re: [Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees

2019-02-27 Thread Thomas Huth
On 28/02/2019 08.14, Gerd Hoffmann wrote: > On Thu, Feb 28, 2019 at 08:01:53AM +0100, Thomas Huth wrote: >> On 28/02/2019 06.00, David Gibson wrote: >>> On Thu, Feb 28, 2019 at 03:35:03PM +1100, Alexey Kardashevskiy wrote: The configure script checks multiple times whether it works in a git >>

Re: [Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees

2019-02-27 Thread Gerd Hoffmann
On Thu, Feb 28, 2019 at 08:01:53AM +0100, Thomas Huth wrote: > On 28/02/2019 06.00, David Gibson wrote: > > On Thu, Feb 28, 2019 at 03:35:03PM +1100, Alexey Kardashevskiy wrote: > >> The configure script checks multiple times whether it works in a git > >> repository and it does this by "test -e "$

Re: [Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees

2019-02-27 Thread Thomas Huth
On 28/02/2019 06.00, David Gibson wrote: > On Thu, Feb 28, 2019 at 03:35:03PM +1100, Alexey Kardashevskiy wrote: >> The configure script checks multiple times whether it works in a git >> repository and it does this by "test -e "${source_path}/.git" in 4 cases >> but in one case where it tries to e

Re: [Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees

2019-02-27 Thread David Gibson
On Thu, Feb 28, 2019 at 03:35:03PM +1100, Alexey Kardashevskiy wrote: > The configure script checks multiple times whether it works in a git > repository and it does this by "test -e "${source_path}/.git" in 4 cases > but in one case where it tries to enable werror "-d" is used there which > fails

[Qemu-devel] [PATCH qemu] configure: Enable werror for git worktrees

2019-02-27 Thread Alexey Kardashevskiy
The configure script checks multiple times whether it works in a git repository and it does this by "test -e "${source_path}/.git" in 4 cases but in one case where it tries to enable werror "-d" is used there which fails on git worktrees as .git is a file then and not a directory. This changes the