Re: [Qemu-devel] [PATCH memory v1 1/1] memory: remove may_overlap property

2014-08-18 Thread Peter Maydell
On 18 August 2014 08:26, Peter Crosthwaite wrote: > On Mon, Aug 18, 2014 at 5:23 PM, Peter Maydell > wrote: >> Oops, I mistakenly thought this check was happening at the >> flattened-ranges point, but it's done when a subregion is >> added to a container. Maybe you're right that we should be >>

Re: [Qemu-devel] [PATCH memory v1 1/1] memory: remove may_overlap property

2014-08-18 Thread Peter Crosthwaite
On Mon, Aug 18, 2014 at 5:23 PM, Peter Maydell wrote: > On 18 August 2014 01:14, Peter Crosthwaite > wrote: >> On Mon, Aug 18, 2014 at 8:23 AM, Peter Maydell >> wrote: >>> On 15 August 2014 08:17, Peter Crosthwaite >>> wrote: If we were to repair this, a simpler and more effective check

Re: [Qemu-devel] [PATCH memory v1 1/1] memory: remove may_overlap property

2014-08-18 Thread Peter Maydell
On 18 August 2014 01:14, Peter Crosthwaite wrote: > On Mon, Aug 18, 2014 at 8:23 AM, Peter Maydell > wrote: >> On 15 August 2014 08:17, Peter Crosthwaite >> wrote: >>> If we were to repair this, a simpler and more effective check would be >>> to only assert collisions between same-priority reg

Re: [Qemu-devel] [PATCH memory v1 1/1] memory: remove may_overlap property

2014-08-17 Thread Peter Crosthwaite
On Mon, Aug 18, 2014 at 8:23 AM, Peter Maydell wrote: > On 15 August 2014 08:17, Peter Crosthwaite > wrote: >> In a5e1cbc80e88ed7d73b3fcb46053a3ba167293fc the enforcement of Memory >> collisions was disabled. This means that the MemoryRegion map_overlap >> state is unused. Remove it completely.

Re: [Qemu-devel] [PATCH memory v1 1/1] memory: remove may_overlap property

2014-08-17 Thread Paolo Bonzini
Il 18/08/2014 00:23, Peter Maydell ha scritto: > Um. I think in general colliding memory regions imply a bug in the > machine model which is creating them. We have the collisions > disabled because nobody's got round to fixing this bug in the > PC model yet and it happens to be harmless there. I'm

Re: [Qemu-devel] [PATCH memory v1 1/1] memory: remove may_overlap property

2014-08-17 Thread Peter Maydell
On 15 August 2014 08:17, Peter Crosthwaite wrote: > In a5e1cbc80e88ed7d73b3fcb46053a3ba167293fc the enforcement of Memory > collisions was disabled. This means that the MemoryRegion map_overlap > state is unused. Remove it completely. > > The commit mentions that it should be fixed, but we have be

Re: [Qemu-devel] [PATCH memory v1 1/1] memory: remove may_overlap property

2014-08-17 Thread Paolo Bonzini
Il 15/08/2014 09:17, Peter Crosthwaite ha scritto: > In a5e1cbc80e88ed7d73b3fcb46053a3ba167293fc the enforcement of Memory > collisions was disabled. This means that the MemoryRegion map_overlap > state is unused. Remove it completely. > > The commit mentions that it should be fixed, but we have b

[Qemu-devel] [PATCH memory v1 1/1] memory: remove may_overlap property

2014-08-15 Thread Peter Crosthwaite
In a5e1cbc80e88ed7d73b3fcb46053a3ba167293fc the enforcement of Memory collisions was disabled. This means that the MemoryRegion map_overlap state is unused. Remove it completely. The commit mentions that it should be fixed, but we have been living happily-every-after since removal of the check so