Re: [Qemu-devel] [PATCH for 3.1] RISC-V: Respect fences for user-only emulators

2018-11-10 Thread Richard Henderson
On 11/9/18 8:19 PM, Palmer Dabbelt wrote: > Our current fence implementation ignores fences for the user-only > configurations. This is incorrect but unlikely to manifest: it requires > multi-threaded user-only code that takes advantage of the weakness in > the host's memory model and can be inlin

Re: [Qemu-devel] [PATCH for 3.1] RISC-V: Respect fences for user-only emulators

2018-11-09 Thread Alistair Francis
On Fri, Nov 9, 2018 at 11:21 AM Palmer Dabbelt wrote: > > Our current fence implementation ignores fences for the user-only > configurations. This is incorrect but unlikely to manifest: it requires > multi-threaded user-only code that takes advantage of the weakness in > the host's memory model a

[Qemu-devel] [PATCH for 3.1] RISC-V: Respect fences for user-only emulators

2018-11-09 Thread Palmer Dabbelt
Our current fence implementation ignores fences for the user-only configurations. This is incorrect but unlikely to manifest: it requires multi-threaded user-only code that takes advantage of the weakness in the host's memory model and can be inlined by TCG. This patch simply treats fences the sa

[Qemu-devel] [PATCH for 3.1] RISC-V: Respect fences for user-only emulators

2018-11-09 Thread Palmer Dabbelt
I'd like to target this for 3.1: while it's a pretty esoteric bug the risk of breaking anything is low and tracking down a manifestation of the bug would be a nightmare. I don't think the performance improvement alluded to will be a 3.1 candidiate, and as a result I probably won't get around to it