Re: [Qemu-devel] [PATCH for 2.12] iotests: Avoid realpath

2018-03-15 Thread Fam Zheng
On Wed, 03/14 09:47, Eric Blake wrote: > > The remaining use was using realpath to convert a possibly > > relative filename into an absolute one before calling diff, > > but diff works just fine on the relative name. > > Hmm, this last change reverts commit 93e53fb6 that added realpath on purpose

Re: [Qemu-devel] [PATCH for 2.12] iotests: Avoid realpath

2018-03-14 Thread Eric Blake
On 03/14/2018 09:38 AM, Eric Blake wrote: CentOS 6 lacks a realpath binary on the base install, which makes all iotests runs fail: 001 - output mismatch (see 001.out.bad) ./check: line 815: realpath: command not found diff: missing operand after `/home/dummy/qemu/tests/qemu-iotests/001.o

[Qemu-devel] [PATCH for 2.12] iotests: Avoid realpath

2018-03-14 Thread Eric Blake
CentOS 6 lacks a realpath binary on the base install, which makes all iotests runs fail: 001 - output mismatch (see 001.out.bad) ./check: line 815: realpath: command not found diff: missing operand after `/home/dummy/qemu/tests/qemu-iotests/001.out' diff: Try `diff --help' for more informa