Re: [Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-25 Thread Alexander Graf
On 16.02.2013, at 12:59, Andreas Färber wrote: > Am 15.02.2013 14:14, schrieb Alexander Graf: >> In parallel to the completely disastrous user experience when using trace >> points. Debug printfs are easy and understandable. Tracepoints are not. >> >> However, how about we take this one gradual

Re: [Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-17 Thread Paolo Bonzini
Il 15/02/2013 14:14, Alexander Graf ha scritto: >> > >> > I'm assuming that changes to ppc logging go through ppc-next, changes to >> > sparc code go through Blue etc. All those potentially conflict since >> > they're adding to the bottom of the same text file, thus coordination. >> > It's a long-

Re: [Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-16 Thread Andreas Färber
Am 15.02.2013 14:14, schrieb Alexander Graf: > In parallel to the completely disastrous user experience when using trace > points. Debug printfs are easy and understandable. Tracepoints are not. > > However, how about we take this one gradually? +1, I'm looking for a minimally invasive solution

Re: [Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-15 Thread Stefan Hajnoczi
On Fri, Feb 15, 2013 at 10:50:16AM +0100, Andreas Färber wrote: > Am 15.02.2013 10:06, schrieb Stefan Hajnoczi: > > In iPXE they use a clever compile-time debug macro: > > https://git.ipxe.org/ipxe.git/blob/HEAD:/src/include/compiler.h#l204 > > > > Basically you do DBG("hello world\n") and it gets

Re: [Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-15 Thread Alexander Graf
On 15.02.2013, at 14:04, Andreas Färber wrote: > Am 15.02.2013 13:51, schrieb Stefan Hajnoczi: >> On Fri, Feb 15, 2013 at 10:50:16AM +0100, Andreas Färber wrote: >>> Am 15.02.2013 10:06, schrieb Stefan Hajnoczi: In iPXE they use a clever compile-time debug macro: https://git.ipxe.org/ip

Re: [Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-15 Thread Andreas Färber
Am 15.02.2013 13:51, schrieb Stefan Hajnoczi: > On Fri, Feb 15, 2013 at 10:50:16AM +0100, Andreas Färber wrote: >> Am 15.02.2013 10:06, schrieb Stefan Hajnoczi: >>> In iPXE they use a clever compile-time debug macro: >>> https://git.ipxe.org/ipxe.git/blob/HEAD:/src/include/compiler.h#l204 >>> >>> B

Re: [Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-15 Thread Andreas Färber
Am 15.02.2013 10:06, schrieb Stefan Hajnoczi: > In iPXE they use a clever compile-time debug macro: > https://git.ipxe.org/ipxe.git/blob/HEAD:/src/include/compiler.h#l204 > > Basically you do DBG("hello world\n") and it gets compiled out by > default using: > if (DBG_LOG) { > printf("hello

Re: [Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-15 Thread Stefan Hajnoczi
On Thu, Feb 14, 2013 at 04:40:29PM +0100, Andreas Färber wrote: > CC'ing some more people from the "debug output revamp" RFC discussion. > > Am 11.02.2013 20:01, schrieb Andreas Färber: > > From: Andreas Färber > > > > Signed-off-by: Andreas Färber > > --- > > hw/tmp105.c | 27 ++

Re: [Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-14 Thread Andreas Färber
CC'ing some more people from the "debug output revamp" RFC discussion. Am 11.02.2013 20:01, schrieb Andreas Färber: > From: Andreas Färber > > Signed-off-by: Andreas Färber > --- > hw/tmp105.c | 27 +-- > 1 Datei geändert, 25 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-

[Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-11 Thread Andreas Färber
From: Andreas Färber Signed-off-by: Andreas Färber --- hw/tmp105.c | 27 +-- 1 Datei geändert, 25 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/hw/tmp105.c b/hw/tmp105.c index 3ad2d2f..5dafa37 100644 --- a/hw/tmp105.c +++ b/hw/tmp105.c @@ -23,6 +23,18 @@ #