Re: [Qemu-devel] [PATCH for-4.1 v2 31/36] cpu: Introduce CPUNegativeOffsetState

2019-04-29 Thread Richard Henderson
On 4/29/19 7:43 AM, Peter Maydell wrote: > It would be nice if we could do a compile-time assert that > offsetof(CPUArchState, neg) + sizeof(CPUNegativeOffsetState) > == offsetof(CPUArchState, env) > > but I guess the possibility of within-struct padding > between the two structs makes that dub

Re: [Qemu-devel] [PATCH for-4.1 v2 31/36] cpu: Introduce CPUNegativeOffsetState

2019-04-29 Thread Peter Maydell
On Thu, 28 Mar 2019 at 23:35, Richard Henderson wrote: > > Nothing in there so far, but all of the plumbing done > within the target ArchCPU state. > > Signed-off-by: Richard Henderson > +/* > + * This structure must be placed in ArchCPU immedately > + * before CPUArchState, as a field named "ne

[Qemu-devel] [PATCH for-4.1 v2 31/36] cpu: Introduce CPUNegativeOffsetState

2019-03-28 Thread Richard Henderson
Nothing in there so far, but all of the plumbing done within the target ArchCPU state. Signed-off-by: Richard Henderson --- include/exec/cpu-all.h | 25 + include/exec/cpu-defs.h | 8 target/alpha/cpu.h | 1 + target/arm/cpu.h| 1 + target/cris/c