Re: [Qemu-devel] [PATCH for-4.1 6/7] ui/vnc: Use qemu_getrandom for make_challenge

2019-03-13 Thread Gerd Hoffmann
On Tue, Mar 12, 2019 at 11:26:29PM -0700, Richard Henderson wrote: > Use a better interface for random numbers than rand, > plus some useless floating point arithmetic. > -int i; > - > -srand(time(NULL)+getpid()+getpid()*987654+rand()); > - > -for (i = 0 ; i < sizeof(vs->challenge) ; i

[Qemu-devel] [PATCH for-4.1 6/7] ui/vnc: Use qemu_getrandom for make_challenge

2019-03-12 Thread Richard Henderson
Use a better interface for random numbers than rand, plus some useless floating point arithmetic. Signed-off-by: Richard Henderson --- ui/vnc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 1871422e1d..cbdfa37c52 100644 --- a/ui/vnc.c +++ b