Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-11 Thread Wei Yang
On Tue, Apr 09, 2019 at 05:00:37PM +0200, Igor Mammedov wrote: >Dummy table (with signature "QEMU") creation came from original SeaBIOS >codebase. And QEMU would have to keep it around if there were Q35 machine >that depended on keeping ACPI tables blob constant size. Luckily there >were no version

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-11 Thread Wei Yang
On Thu, Apr 11, 2019 at 01:46:27PM +0200, Igor Mammedov wrote: >On Thu, 11 Apr 2019 09:32:11 +0800 >Wei Yang wrote: > [...] >> To be honest, this is what I feel confused in your previous reply. >> >> First I want to confirm both fields in RAMBlock affects the migration: >> >> * used_length >>

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-11 Thread Igor Mammedov
On Thu, 11 Apr 2019 09:32:11 +0800 Wei Yang wrote: > On Wed, Apr 10, 2019 at 05:01:50PM +0200, Igor Mammedov wrote: > >On Wed, 10 Apr 2019 22:27:56 +0800 > >Wei Yang wrote: > > > >[...] > >> >@@ -2411,19 +2410,7 @@ build_mcfg_q35(GArray *table_data, BIOSLinker > >> >*linker, AcpiMcfgInfo *inf

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-10 Thread Wei Yang
On Wed, Apr 10, 2019 at 05:01:50PM +0200, Igor Mammedov wrote: >On Wed, 10 Apr 2019 22:27:56 +0800 >Wei Yang wrote: > >[...] >> >@@ -2411,19 +2410,7 @@ build_mcfg_q35(GArray *table_data, BIOSLinker >> >*linker, AcpiMcfgInfo *info) >> > mcfg->allocation[0].start_bus_number = 0; >> > mcfg->

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-10 Thread Igor Mammedov
On Wed, 10 Apr 2019 22:27:56 +0800 Wei Yang wrote: [...] > >@@ -2411,19 +2410,7 @@ build_mcfg_q35(GArray *table_data, BIOSLinker > >*linker, AcpiMcfgInfo *info) > > mcfg->allocation[0].start_bus_number = 0; > > mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(info->mcfg_size - > > 1)

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-10 Thread Wei Yang
On Tue, Apr 09, 2019 at 05:00:37PM +0200, Igor Mammedov wrote: >Dummy table (with signature "QEMU") creation came from original SeaBIOS >codebase. And QEMU would have to keep it around if there were Q35 machine >that depended on keeping ACPI tables blob constant size. Luckily there >were no version

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-10 Thread Igor Mammedov
On Wed, 10 Apr 2019 22:01:53 +0800 Wei Yang wrote: > On Wed, Apr 10, 2019 at 11:08:33AM +0200, Igor Mammedov wrote: > >On Wed, 10 Apr 2019 09:12:31 +0800 > >Wei Yang wrote: > > > >> On Tue, Apr 09, 2019 at 05:00:37PM +0200, Igor Mammedov wrote: > >> >Dummy table (with signature "QEMU") creat

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-10 Thread Wei Yang
On Wed, Apr 10, 2019 at 11:08:33AM +0200, Igor Mammedov wrote: >On Wed, 10 Apr 2019 09:12:31 +0800 >Wei Yang wrote: > >> On Tue, Apr 09, 2019 at 05:00:37PM +0200, Igor Mammedov wrote: >> >Dummy table (with signature "QEMU") creation came from original SeaBIOS >> >codebase. And QEMU would have to k

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-10 Thread Igor Mammedov
On Wed, 10 Apr 2019 09:12:31 +0800 Wei Yang wrote: > On Tue, Apr 09, 2019 at 05:00:37PM +0200, Igor Mammedov wrote: > >Dummy table (with signature "QEMU") creation came from original SeaBIOS > >codebase. And QEMU would have to keep it around if there were Q35 machine > >that depended on keeping A

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-09 Thread Wei Yang
On Tue, Apr 09, 2019 at 05:00:37PM +0200, Igor Mammedov wrote: >Dummy table (with signature "QEMU") creation came from original SeaBIOS >codebase. And QEMU would have to keep it around if there were Q35 machine >that depended on keeping ACPI tables blob constant size. Luckily there >were no version

[Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-09 Thread Igor Mammedov
Dummy table (with signature "QEMU") creation came from original SeaBIOS codebase. And QEMU would have to keep it around if there were Q35 machine that depended on keeping ACPI tables blob constant size. Luckily there were no versioned Q35 machine types before commit: (since 2.3) a1666142db acpi-b