Re: [Qemu-devel] [PATCH for-4.1] hw: add compat machines for 4.1

2019-04-12 Thread Eduardo Habkost
On Thu, Apr 11, 2019 at 12:56:55PM +0200, Cornelia Huck wrote: > On Thu, 11 Apr 2019 03:28:46 -0700 (PDT) > no-re...@patchew.org wrote: > > > === OUTPUT BEGIN === > > ERROR: spaces required around that '=' (ctx:WxV) > > #58: FILE: hw/i386/pc.c:118: > > +GlobalProperty pc_compat_4_0[] ={}; > >

Re: [Qemu-devel] [PATCH for-4.1] hw: add compat machines for 4.1

2019-04-12 Thread Eduardo Habkost
On Thu, Apr 11, 2019 at 12:20:25PM +0200, Cornelia Huck wrote: > Add 4.1 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck Thanks! Reviewed-by: Eduardo Habkost I'm queueing it on machine-next. -- Eduardo

Re: [Qemu-devel] [PATCH for-4.1] hw: add compat machines for 4.1

2019-04-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190411102025.22559-1-coh...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190411102025.22559-1-coh...@redhat.com Subject: [Qemu-devel] [PATCH for-4.1] hw: add compat machines

Re: [Qemu-devel] [PATCH for-4.1] hw: add compat machines for 4.1

2019-04-11 Thread Cornelia Huck
On Thu, 11 Apr 2019 03:28:46 -0700 (PDT) no-re...@patchew.org wrote: > === OUTPUT BEGIN === > ERROR: spaces required around that '=' (ctx:WxV) > #58: FILE: hw/i386/pc.c:118: > +GlobalProperty pc_compat_4_0[] ={}; > ^ > > total: 1 errors, 0 warnings, 160 lines check

[Qemu-devel] [PATCH for-4.1] hw: add compat machines for 4.1

2019-04-11 Thread Cornelia Huck
Add 4.1 machine types for arm/i440fx/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- IIRC, we agreed last time that we want to merge a patch introducing the new compat machines first thing in a new development cycle. So here's that patch for 4.1. --- hw/arm/virt.c | 9 -