Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

On 4/8/19 8:21 AM, Olaf Hering wrote: > Am Fri, 5 Apr 2019 19:17:35 -0400 > schrieb "Michael S. Tsirkin" : > >> Let's keep it simple: set a config variable, then check it here. > > Better revert f590a812c21074e82228de3e1dfb57b75fc02b62 and > 23858f4092fc9ebf9e7a5e5110e44abef6fc6643 for the time

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

Am Fri, 5 Apr 2019 19:17:35 -0400 schrieb "Michael S. Tsirkin" : > Let's keep it simple: set a config variable, then check it here. Better revert f590a812c21074e82228de3e1dfb57b75fc02b62 and 23858f4092fc9ebf9e7a5e5110e44abef6fc6643 for the time being. It looks like a no-op right now. How did pe

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

On Fri, Apr 05, 2019 at 03:14:30PM +0200, Philippe Mathieu-Daudé wrote: > On 4/5/19 3:04 PM, Olaf Hering wrote: > > Am Fri, 5 Apr 2019 14:59:16 +0200 > > schrieb Philippe Mathieu-Daudé : > >> On 4/5/19 2:09 PM, Olaf Hering wrote: > >>> Am Fri, 5 Apr 2019 13:55:29 +0200 > >>> schrieb Philippe Mathi

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

On 4/5/19 3:04 PM, Olaf Hering wrote: > Am Fri, 5 Apr 2019 14:59:16 +0200 > schrieb Philippe Mathieu-Daudé : >> On 4/5/19 2:09 PM, Olaf Hering wrote: >>> Am Fri, 5 Apr 2019 13:55:29 +0200 >>> schrieb Philippe Mathieu-Daudé : >>> +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom >>> >>> This

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

Am Fri, 5 Apr 2019 14:59:16 +0200 schrieb Philippe Mathieu-Daudé : > On 4/5/19 2:09 PM, Olaf Hering wrote: > > Am Fri, 5 Apr 2019 13:55:29 +0200 > > schrieb Philippe Mathieu-Daudé : > > > >> +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom > > > > This name is too generic and will conflict wit

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

On 4/5/19 2:09 PM, Olaf Hering wrote: > Am Fri, 5 Apr 2019 13:55:29 +0200 > schrieb Philippe Mathieu-Daudé : > >> +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom > > This name is too generic and will conflict with ipxe.git if any of "bios > seavgabios pxerom" is used for 'make -C roms'. This is

Re: [Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

Am Fri, 5 Apr 2019 13:55:29 +0200 schrieb Philippe Mathieu-Daudé : > +EFIROM ?= edk2/BaseTools/Source/C/bin/EfiRom This name is too generic and will conflict with ipxe.git if any of "bios seavgabios pxerom" is used for 'make -C roms'. Olaf pgpFSdFcL3tvf.pgp Description: Digitale Signatur von

[Qemu-devel] [PATCH for-4.0] roms: Allow the EFIROM variable to be overridden

Since commit f590a812c210 we build the EfiRom utility unconditionally. This has been tested on all the Linux distribution providing continuous integration (namely Debian and Fedora). Not all distributions are able to build the EfiRom without specific patches (In particular SUSE which enforces the P