Re: [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash

2019-04-05 Thread Kevin Wolf
Am 05.04.2019 um 18:11 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben: > > > drive_new() returns null without setting an error when it provided > > > help. add_init_drive() assumes null means failure, an

Re: [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash

2019-04-05 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben: > > drive_new() returns null without setting an error when it provided > > help. add_init_drive() assumes null means failure, and crashes trying > > to report a null error. > > > > Fixes: c4f26c9f37

Re: [Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash

2019-04-05 Thread Kevin Wolf
Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben: > drive_new() returns null without setting an error when it provided > help. add_init_drive() assumes null means failure, and crashes trying > to report a null error. > > Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25 > Cc: qemu-sta...@no

[Qemu-devel] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash

2019-04-05 Thread Markus Armbruster
drive_new() returns null without setting an error when it provided help. add_init_drive() assumes null means failure, and crashes trying to report a null error. Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25 Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster --- device-hotplug.c | 2 +