Re: [Qemu-devel] [PATCH for-3.2 10/13] slirp: improve subprocess socket creation

2018-11-10 Thread Samuel Thibault
Peter Maydell, le sam. 10 nov. 2018 14:04:10 +, a ecrit: > On 10 November 2018 at 13:53, Samuel Thibault wrote: > > Marc-André Lureau, le sam. 10 nov. 2018 17:45:45 +0400, a ecrit: > >> @@ -163,23 +183,14 @@ fork_exec(struct socket *so, const char *ex) > >> exit(1); > >> > >>

Re: [Qemu-devel] [PATCH for-3.2 10/13] slirp: improve subprocess socket creation

2018-11-10 Thread Peter Maydell
On 10 November 2018 at 13:53, Samuel Thibault wrote: > Marc-André Lureau, le sam. 10 nov. 2018 17:45:45 +0400, a ecrit: >> @@ -163,23 +183,14 @@ fork_exec(struct socket *so, const char *ex) >> exit(1); >> >>default: >> - qemu_add_child_watch(pid); >> -

Re: [Qemu-devel] [PATCH for-3.2 10/13] slirp: improve subprocess socket creation

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:45 +0400, a ecrit: > @@ -163,23 +183,14 @@ fork_exec(struct socket *so, const char *ex) > exit(1); > >default: > - qemu_add_child_watch(pid); > -/* > - * XXX this could block us... > -

[Qemu-devel] [PATCH for-3.2 10/13] slirp: improve subprocess socket creation

2018-11-10 Thread Marc-André Lureau
Fix a bunch of error handling issues by creating the "TCP socketpair" from the parent process. (the code is currently disabled on Windows: at first I thought a socketpair() could be used, but I realized that slirp calls MSG_OOB on the socket, which isn't implemented on Linux) Signed-off-by: Marc-A