Re: [Qemu-devel] [PATCH for-3.2 05/13] slirp: remove unused EMU_RSH

2018-11-15 Thread Paolo Bonzini
On 10/11/2018 14:45, Marc-André Lureau wrote: > EMU_RSH handling was dropped in commit > 0d62c4cfe21752df4c1d6e2c2398f15d5eaa794a. > > The assignment, and subsequent free() of ex_ptr->ex_exec to so->extra > looks unsafe (double free is likely to occur). > > Signed-off-by: Marc-André Lureau > ---

Re: [Qemu-devel] [PATCH for-3.2 05/13] slirp: remove unused EMU_RSH

2018-11-10 Thread Samuel Thibault
Marc-André Lureau, le sam. 10 nov. 2018 17:45:40 +0400, a ecrit: > EMU_RSH handling was dropped in commit > 0d62c4cfe21752df4c1d6e2c2398f15d5eaa794a. > > The assignment, and subsequent free() of ex_ptr->ex_exec to so->extra > looks unsafe (double free is likely to occur). Applied to my tree, than

[Qemu-devel] [PATCH for-3.2 05/13] slirp: remove unused EMU_RSH

2018-11-10 Thread Marc-André Lureau
EMU_RSH handling was dropped in commit 0d62c4cfe21752df4c1d6e2c2398f15d5eaa794a. The assignment, and subsequent free() of ex_ptr->ex_exec to so->extra looks unsafe (double free is likely to occur). Signed-off-by: Marc-André Lureau --- slirp/misc.h | 1 - slirp/slirp.c| 2 -- slirp/socke