Re: [Qemu-devel] [PATCH for-3.1 0/2] Fix disas/nanomips

2018-11-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH for-3.1 0/2] Fix disas/nanomips Message-id: 20181127121724.19755-1...@weilnetz.de === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH for-3.1 0/2] Fix disas/nanomips

2018-11-27 Thread Aleksandar Markovic
Stefan Weil wrote: > These two patches fix wrong format strings used in disas/nanomips. Stefan, I truly appreciate your interest in nanoMIPS dissasembler. In my opinion, this series comes too late in 3.1 development cycle to be accepted. The described severity of undesired behavior is just way

Re: [Qemu-devel] [PATCH for-3.1 0/2] Fix disas/nanomips

2018-11-27 Thread Stefan Weil
Am 27.11.2018 um 13:36 schrieb Peter Maydell: > On Tue, 27 Nov 2018 at 12:17, Stefan Weil wrote: >> These two patches fix wrong format strings used in disas/nanomips. >> >> The first patch replaces proprietary data types by POSIX data types, >> because otherwise the PRI... macros cannot be used in

Re: [Qemu-devel] [PATCH for-3.1 0/2] Fix disas/nanomips

2018-11-27 Thread Peter Maydell
On Tue, 27 Nov 2018 at 12:17, Stefan Weil wrote: > > These two patches fix wrong format strings used in disas/nanomips. > > The first patch replaces proprietary data types by POSIX data types, > because otherwise the PRI... macros cannot be used in the second patch. I think this is a good idea, b

[Qemu-devel] [PATCH for-3.1 0/2] Fix disas/nanomips

2018-11-27 Thread Stefan Weil
These two patches fix wrong format strings used in disas/nanomips. The first patch replaces proprietary data types by POSIX data types, because otherwise the PRI... macros cannot be used in the second patch. Those patches are only relevant for 3.1 if full nanomips support is considered important