Re: [Qemu-devel] [PATCH for-3.1] replay: Exit on errors reading from replay log

2018-11-08 Thread Peter Maydell
On 6 November 2018 at 22:19, Paolo Bonzini wrote: > On 06/11/2018 16:33, Peter Maydell wrote: >> Currently replay_get_byte() does not check for an error >> from getc(). Coverity points out (CID 1390622) that this >> could result in unexpected behaviour (such as looping >> forever, if we use the re

Re: [Qemu-devel] [PATCH for-3.1] replay: Exit on errors reading from replay log

2018-11-06 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Currently replay_get_byte() does not check for an error > from getc(). Coverity points out (CID 1390622) that this > could result in unexpected behaviour (such as looping > forever, if we use the replay_get_dword() return value > for a loop

Re: [Qemu-devel] [PATCH for-3.1] replay: Exit on errors reading from replay log

2018-11-06 Thread Paolo Bonzini
On 06/11/2018 16:33, Peter Maydell wrote: > Currently replay_get_byte() does not check for an error > from getc(). Coverity points out (CID 1390622) that this > could result in unexpected behaviour (such as looping > forever, if we use the replay_get_dword() return value > for a loop count). We don

[Qemu-devel] [PATCH for-3.1] replay: Exit on errors reading from replay log

2018-11-06 Thread Peter Maydell
Currently replay_get_byte() does not check for an error from getc(). Coverity points out (CID 1390622) that this could result in unexpected behaviour (such as looping forever, if we use the replay_get_dword() return value for a loop count). We don't expect reads from the replay log to fail, and if