Re: [Qemu-devel] [PATCH for-2.9] Fix check for target OS support

2017-03-28 Thread Peter Maydell
On 28 March 2017 at 13:07, Stefan Weil wrote: > Am 28.03.2017 um 09:10 schrieb Peter Maydell: >> On 27 March 2017 at 21:11, Stefan Weil wrote: >>> *) >>> - error_exit "Unsupported host OS $targetos" >>> + supported_os="no" >> This was deliberately an error_exit because anything >> going down t

Re: [Qemu-devel] [PATCH for-2.9] Fix check for target OS support

2017-03-28 Thread Stefan Weil
Am 28.03.2017 um 09:10 schrieb Peter Maydell: > On 27 March 2017 at 21:11, Stefan Weil wrote: >> This check had several problems which are fixed here: >> >> * Calling "configure --help" was no longer possible on Cygwin. >> Fix this by introducing a third state for supported_os and >> by movin

Re: [Qemu-devel] [PATCH for-2.9] Fix check for target OS support

2017-03-28 Thread Mark Cave-Ayland
On 28/03/17 12:53, Stefan Weil wrote: > You are right. I was wrong because of this use case: > > $ ./configure '--enable-debug' '--cross-prefix=x86_64-w64-mingw32' > > ERROR: Unsupported host OS CYGWIN_NT-6.1 > > So the error message is misleading when I specify a wrong cross prefix > (it shoul

Re: [Qemu-devel] [PATCH for-2.9] Fix check for target OS support

2017-03-28 Thread Peter Maydell
On 28 March 2017 at 12:53, Stefan Weil wrote: > Am 28.03.2017 um 10:04 schrieb Paolo Bonzini: >> On 27/03/2017 22:11, Stefan Weil wrote: >>> * Support cross compilation with the most common cross prefixes >>> for Mingw-w64. Other cross builds are still broken! >> Can you explain how it's broken?

Re: [Qemu-devel] [PATCH for-2.9] Fix check for target OS support

2017-03-28 Thread Stefan Weil
Am 28.03.2017 um 10:04 schrieb Paolo Bonzini: > On 27/03/2017 22:11, Stefan Weil wrote: >> * Support cross compilation with the most common cross prefixes >> for Mingw-w64. Other cross builds are still broken! > Can you explain how it's broken? Why does check_define not work at this > point, for

Re: [Qemu-devel] [PATCH for-2.9] Fix check for target OS support

2017-03-28 Thread Paolo Bonzini
On 27/03/2017 22:11, Stefan Weil wrote: > * Support cross compilation with the most common cross prefixes > for Mingw-w64. Other cross builds are still broken! Can you explain how it's broken? Why does check_define not work at this point, for cross builds? "../configure --cross-prefix=x86_64

Re: [Qemu-devel] [PATCH for-2.9] Fix check for target OS support

2017-03-28 Thread Peter Maydell
On 27 March 2017 at 21:11, Stefan Weil wrote: > This check had several problems which are fixed here: > > * Calling "configure --help" was no longer possible on Cygwin. > Fix this by introducing a third state for supported_os and > by moving the error handling code. > Move the error handlin

[Qemu-devel] [PATCH for-2.9] Fix check for target OS support

2017-03-27 Thread Stefan Weil
This check had several problems which are fixed here: * Calling "configure --help" was no longer possible on Cygwin. Fix this by introducing a third state for supported_os and by moving the error handling code. Move the error handling code for supported_cpu, too. * Fix the error text. Use