Re: [Qemu-devel] [PATCH for-2.8 v1 05/60] trace: add trace event iterator APIs

2016-09-14 Thread Daniel P. Berrange
On Fri, Sep 02, 2016 at 04:52:18PM -0400, Stefan Hajnoczi wrote: > On Tue, Aug 09, 2016 at 04:31:33PM +0100, Daniel P. Berrange wrote: > > +TraceEvent *trace_event_iter_next(TraceEventIter *iter) > > +{ > > +TraceEvent *ev; > > + > > +if (iter->event >= TRACE_EVENT_COUNT) { > > +ret

Re: [Qemu-devel] [PATCH for-2.8 v1 05/60] trace: add trace event iterator APIs

2016-09-02 Thread Stefan Hajnoczi
On Tue, Aug 09, 2016 at 04:31:33PM +0100, Daniel P. Berrange wrote: > +TraceEvent *trace_event_iter_next(TraceEventIter *iter) > +{ > +TraceEvent *ev; > + > +if (iter->event >= TRACE_EVENT_COUNT) { > +return NULL; > +} > + > +ev = &(trace_events[iter->event]); > + > +do

[Qemu-devel] [PATCH for-2.8 v1 05/60] trace: add trace event iterator APIs

2016-08-09 Thread Daniel P. Berrange
Currently methods which want to iterate over trace events, do so using the trace_event_count() and trace_event_id() methods. This leaks the concept of a single ID enum to the callers. There is an alternative trace_event_pattern() method which can be used in an iteration context, but its design is s