On 5 December 2016 at 17:22, Richard Henderson wrote:
> Acked-by: Richard Henderson
Thanks. I've put this into a one-patch pullrequest which I've just
sent out and which will hopefully make -rc3.
thanks
-- PMM
On 12/05/2016 03:09 AM, Alex Bennée wrote:
>
> Alex Bennée writes:
>
>> While testing rth's latest TCG patches with risu I found ldaxp was
>> broken. Investigating further I found it was broken by 1dd089d0 when
>> the cmpxchg atomic work was merged.
>
> CC'ing Paolo/Richard
>
> Do you guys hav
On 12/05/2016 09:04 AM, Alex Bennée wrote:
>> It's not trying to be "clever", it's trying to be correct, giving an atomic
>> 64-bit load.
>
> Ahh right I see. What happens if the backend is 32bit, will it issue two
> loads anyway?
Yes. I did bring this up when the atomics patch set went in.
In
Richard Henderson writes:
> On 12/05/2016 03:09 AM, Alex Bennée wrote:
>>
>> Alex Bennée writes:
>>
>>> While testing rth's latest TCG patches with risu I found ldaxp was
>>> broken. Investigating further I found it was broken by 1dd089d0 when
>>> the cmpxchg atomic work was merged.
>>
>> CC'in
On 5 December 2016 at 15:42, Richard Henderson wrote:
> We'll have to fix it properly eventually. But perhaps 2.9 is soon enough,
> since that's when mttcg will go in.
Could you provide a reviewed-by (or an explicit nak) for Alex's
patch, please? I didn't look at this area of the code when it
we
On 12/05/2016 03:09 AM, Alex Bennée wrote:
>
> Alex Bennée writes:
>
>> While testing rth's latest TCG patches with risu I found ldaxp was
>> broken. Investigating further I found it was broken by 1dd089d0 when
>> the cmpxchg atomic work was merged.
>
> CC'ing Paolo/Richard
>
> Do you guys hav
Alex Bennée writes:
> While testing rth's latest TCG patches with risu I found ldaxp was
> broken. Investigating further I found it was broken by 1dd089d0 when
> the cmpxchg atomic work was merged.
CC'ing Paolo/Richard
Do you guys have any final TCG fixes planned for 2.8 that can take this
fix
While testing rth's latest TCG patches with risu I found ldaxp was
broken. Investigating further I found it was broken by 1dd089d0 when
the cmpxchg atomic work was merged. As part of that change the code
attempted to be clever by doing a single 64 bit load and then shuffle
the data around to set th
