Re: [Qemu-devel] [PATCH for-2.8] exec.c: Fix breakpoint invalidation race

2016-12-06 Thread Stefan Hajnoczi
On Tue, Dec 06, 2016 at 06:07:09PM +, Peter Maydell wrote: > A bug (1647683) was reported showing a crash when removing > breakpoints. The reproducer was bisected to 3359baad when tb_flush > was finally made thread safe. While in MTTCG the locking in > breakpoint_invalidate would have prevent

Re: [Qemu-devel] [PATCH for-2.8] exec.c: Fix breakpoint invalidation race

2016-12-06 Thread Alex Bennée
Peter Maydell writes: > A bug (1647683) was reported showing a crash when removing > breakpoints. The reproducer was bisected to 3359baad when tb_flush > was finally made thread safe. While in MTTCG the locking in > breakpoint_invalidate would have prevented any problems, but > currently tb_lo

[Qemu-devel] [PATCH for-2.8] exec.c: Fix breakpoint invalidation race

2016-12-06 Thread Peter Maydell
A bug (1647683) was reported showing a crash when removing breakpoints. The reproducer was bisected to 3359baad when tb_flush was finally made thread safe. While in MTTCG the locking in breakpoint_invalidate would have prevented any problems, but currently tb_lock() is a NOP for system emulation.