Re: [Qemu-devel] [PATCH for-2.8] block: Don't mark node clean after failed flush

2016-11-07 Thread John Snow
On 11/04/2016 07:03 PM, Kevin Wolf wrote: Commit 3ff2f67a changed bdrv_co_flush() so that no flush is issues if the image hasn't been dirtied since the last flush. This is not quite correct: The condition should be that the image hasn't been dirtied since the last _successful_ flush. This patch

Re: [Qemu-devel] [PATCH for-2.8] block: Don't mark node clean after failed flush

2016-11-04 Thread Denis V. Lunev
On 11/05/2016 02:03 AM, Kevin Wolf wrote: > Commit 3ff2f67a changed bdrv_co_flush() so that no flush is issues if > the image hasn't been dirtied since the last flush. This is not quite > correct: The condition should be that the image hasn't been dirtied > since the last _successful_ flush. This p

[Qemu-devel] [PATCH for-2.8] block: Don't mark node clean after failed flush

2016-11-04 Thread Kevin Wolf
Commit 3ff2f67a changed bdrv_co_flush() so that no flush is issues if the image hasn't been dirtied since the last flush. This is not quite correct: The condition should be that the image hasn't been dirtied since the last _successful_ flush. This patch changes the logic accordingly. Without this