Re: [Qemu-devel] [PATCH for-2.6] nbd: don't request FUA on FLUSH

2016-04-04 Thread Paolo Bonzini
On 01/04/2016 18:08, Eric Blake wrote: > The NBD protocol does not clearly document what will happen > if a client sends NBD_CMD_FLAG_FUA on NBD_CMD_FLUSH. > Historically, both the qemu and upstream NBD servers silently > ignored that flag, but that feels a bit risky. Meanwhile, the > qemu NBD c

[Qemu-devel] [PATCH for-2.6] nbd: don't request FUA on FLUSH

2016-04-01 Thread Eric Blake
The NBD protocol does not clearly document what will happen if a client sends NBD_CMD_FLAG_FUA on NBD_CMD_FLUSH. Historically, both the qemu and upstream NBD servers silently ignored that flag, but that feels a bit risky. Meanwhile, the qemu NBD client unconditionally sends the flag (without even