Re: [Qemu-devel] [PATCH for-2.5 15/30] m68k: add more modes to movem

2015-08-12 Thread Richard Henderson
On 08/12/2015 01:07 AM, Andreas Schwab wrote: > Richard Henderson writes: > >> On 08/09/2015 01:13 PM, Laurent Vivier wrote: >>> +opsize = (insn & 0x40) != 0 ? OS_LONG : OS_WORD; >>> +incr = opsize_bytes(opsize); >>> +if (!is_load && (insn & 070) == 040) { >>> +for (i = 15; i

Re: [Qemu-devel] [PATCH for-2.5 15/30] m68k: add more modes to movem

2015-08-12 Thread Andreas Schwab
Richard Henderson writes: > On 08/09/2015 01:13 PM, Laurent Vivier wrote: >> +opsize = (insn & 0x40) != 0 ? OS_LONG : OS_WORD; >> +incr = opsize_bytes(opsize); >> +if (!is_load && (insn & 070) == 040) { >> +for (i = 15; i >= 0; i--, mask >>= 1) { > > This has got to be wrong.

Re: [Qemu-devel] [PATCH for-2.5 15/30] m68k: add more modes to movem

2015-08-12 Thread Richard Henderson
On 08/09/2015 01:13 PM, Laurent Vivier wrote: +opsize = (insn & 0x40) != 0 ? OS_LONG : OS_WORD; +incr = opsize_bytes(opsize); +if (!is_load && (insn & 070) == 040) { +for (i = 15; i >= 0; i--, mask >>= 1) { This has got to be wrong. Just because it's pre-decrement doesn't m

[Qemu-devel] [PATCH for-2.5 15/30] m68k: add more modes to movem

2015-08-09 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 52 - 1 file changed, 39 insertions(+), 13 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index f52aca3..d3a3695 100644 --- a/target-m68k/translate.c +++ b/tar