Re: [Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly

2015-12-03 Thread David Gibson
On Thu, Dec 03, 2015 at 05:37:38PM +0100, Markus Armbruster wrote: > Since prop_get_fdt() is only used with QmpOutputVisitor, errors > shouldn't actually happen, so this is only a latent bug. > > Signed-off-by: Markus Armbruster Acked-by: David Gibson > --- > hw/ppc/spapr_drc.c | 32 +

Re: [Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly

2015-12-03 Thread Eric Blake
On 12/03/2015 09:37 AM, Markus Armbruster wrote: > Since prop_get_fdt() is only used with QmpOutputVisitor, errors > shouldn't actually happen, so this is only a latent bug. > > Signed-off-by: Markus Armbruster > --- > hw/ppc/spapr_drc.c | 32 ++-- > 1 file changed, 2

[Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly

2015-12-03 Thread Markus Armbruster
Since prop_get_fdt() is only used with QmpOutputVisitor, errors shouldn't actually happen, so this is only a latent bug. Signed-off-by: Markus Armbruster --- hw/ppc/spapr_drc.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/hw/ppc/spapr_drc.