Re: [Qemu-devel] [PATCH for-2.5 1/2] input: Avoid CamelCase in InputEvent enums

2015-11-12 Thread Eric Blake
On 11/12/2015 01:23 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Our documentation states that we prefer 'lower-case', rather than >> 'CamelCase', for qapi enum values. The InputButton and InputAxis >> enums violated this convention. However, they are currently used >> primarily for g

Re: [Qemu-devel] [PATCH for-2.5 1/2] input: Avoid CamelCase in InputEvent enums

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > Our documentation states that we prefer 'lower-case', rather than > 'CamelCase', for qapi enum values. The InputButton and InputAxis > enums violated this convention. However, they are currently used > primarily for generating code that is used internally; their only > expo

[Qemu-devel] [PATCH for-2.5 1/2] input: Avoid CamelCase in InputEvent enums

2015-11-11 Thread Eric Blake
Our documentation states that we prefer 'lower-case', rather than 'CamelCase', for qapi enum values. The InputButton and InputAxis enums violated this convention. However, they are currently used primarily for generating code that is used internally; their only exposure through QMP is via the exp