Re: [Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage

2015-11-23 Thread Stefan Hajnoczi
On Mon, Nov 23, 2015 at 05:31:33PM +0100, Juan Quintela wrote: > Wen Congyang wrote: > > If we set migration speed in a very large value, block-migration will try > > to read > > all data to the memory. Because > > (block_mig_state.submitted + block_mig_state.read_done) * BLOCK_SIZE > > will

Re: [Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage

2015-11-23 Thread Juan Quintela
Wen Congyang wrote: > If we set migration speed in a very large value, block-migration will try to > read > all data to the memory. Because > (block_mig_state.submitted + block_mig_state.read_done) * BLOCK_SIZE > will be overflow, and it will be always less than rate limit. > > There is no ne

[Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage

2015-11-20 Thread Wen Congyang
If we set migration speed in a very large value, block-migration will try to read all data to the memory. Because (block_mig_state.submitted + block_mig_state.read_done) * BLOCK_SIZE will be overflow, and it will be always less than rate limit. There is no need to read too many data into memo