Re: [Qemu-devel] [PATCH for-2.4] vnc: fix memory leak

2015-07-23 Thread Gonglei
On 2015/7/23 13:36, Paolo Bonzini wrote: > > > On 23/07/2015 06:22, Amit Shah wrote: >> On (Wed) 22 Jul 2015 [10:19:52], Daniel P. Berrange wrote: On Wed, Jul 22, 2015 at 05:08:53PM +0800, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> If vnc's password is configured, it

Re: [Qemu-devel] [PATCH for-2.4] vnc: fix memory leak

2015-07-22 Thread Paolo Bonzini
On 23/07/2015 06:22, Amit Shah wrote: > On (Wed) 22 Jul 2015 [10:19:52], Daniel P. Berrange wrote: >> > On Wed, Jul 22, 2015 at 05:08:53PM +0800, arei.gong...@huawei.com wrote: >>> > > From: Gonglei >>> > > >>> > > If vnc's password is configured, it will leak memory >>> > > which cipher variab

Re: [Qemu-devel] [PATCH for-2.4] vnc: fix memory leak

2015-07-22 Thread Amit Shah
On (Wed) 22 Jul 2015 [10:19:52], Daniel P. Berrange wrote: > On Wed, Jul 22, 2015 at 05:08:53PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > If vnc's password is configured, it will leak memory > > which cipher variable pointed on every vnc connection. > > > > Cc: Daniel P. Be

Re: [Qemu-devel] [PATCH for-2.4] vnc: fix memory leak

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 05:08:53PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > If vnc's password is configured, it will leak memory > which cipher variable pointed on every vnc connection. > > Cc: Daniel P. Berrange > Signed-off-by: Gonglei Reviewed-by: Daniel P. Berrange Reg

[Qemu-devel] [PATCH for-2.4] vnc: fix memory leak

2015-07-22 Thread arei.gonglei
From: Gonglei If vnc's password is configured, it will leak memory which cipher variable pointed on every vnc connection. Cc: Daniel P. Berrange Signed-off-by: Gonglei --- ui/vnc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 1483958..e2697