Re: [Qemu-devel] [PATCH for-2.3 3/6] vmdk: Clean up descriptor file reading

2014-12-02 Thread Fam Zheng
On Tue, 12/02 12:10, Don Koch wrote: > On Tue, 2 Dec 2014 15:39:14 +0800 > Fam Zheng wrote: > > > Zeroing a buffer that will be filled right after is not necessary, and > > allocating a power of two + 1 is naughty. > > > > Suggested-by: Markus Armbruster > > Signed-off-by: Fam Zheng > > --- >

Re: [Qemu-devel] [PATCH for-2.3 3/6] vmdk: Clean up descriptor file reading

2014-12-02 Thread Don Koch
On Tue, 2 Dec 2014 15:39:14 +0800 Fam Zheng wrote: > Zeroing a buffer that will be filled right after is not necessary, and > allocating a power of two + 1 is naughty. > > Suggested-by: Markus Armbruster > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 5 +++-- > 1 file changed, 3 insertions

[Qemu-devel] [PATCH for-2.3 3/6] vmdk: Clean up descriptor file reading

2014-12-01 Thread Fam Zheng
Zeroing a buffer that will be filled right after is not necessary, and allocating a power of two + 1 is naughty. Suggested-by: Markus Armbruster Signed-off-by: Fam Zheng --- block/vmdk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 2