Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-21 Thread Igor Mammedov
On Mon, 10 Nov 2014 16:20:50 + Igor Mammedov wrote: > If QEMU is started with -numa ... Windows only notices that > CPU has been hot-added but it will not online such CPUs. > > It's caused by the fact that possible CPUs are flagged as > not enabled in SRAT and Windows honoring that informat

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-11 Thread Igor Mammedov
On Tue, 11 Nov 2014 12:08:06 +0100 Paolo Bonzini wrote: > > > On 11/11/2014 09:35, Igor Mammedov wrote: > > > > > > No, I mean can you do it also for pc-2.1 and earlier? Or should it be > > > only for the last machine type? > > > > As Michael sad it's for all machine types or have you meant

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-11 Thread Paolo Bonzini
On 11/11/2014 09:35, Igor Mammedov wrote: > > > > No, I mean can you do it also for pc-2.1 and earlier? Or should it be > > only for the last machine type? > > As Michael sad it's for all machine types or have you meant 2.1 stable > branch? My thought was that it's closed now. I meant pc-2.1.

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-11 Thread Igor Mammedov
On Mon, 10 Nov 2014 18:56:30 +0100 Paolo Bonzini wrote: > > > On 10/11/2014 18:48, Igor Mammedov wrote: > >> > Does this need to be specific to pc-2.2? > > Why not, It's bug fix. > > But I don't care if it's merged later. > > No, I mean can you do it also for pc-2.1 and earlier? Or should it

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Paolo Bonzini
On 10/11/2014 19:34, Michael S. Tsirkin wrote: > > It changes the contents of the SRAT. There is a possibility that it > > triggers bugs in previously working guests. > > Absolutely but that's true for any bugfix. > We don't do compatiblity without a good reason. > > Or do you mean that you co

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Michael S. Tsirkin
On Mon, Nov 10, 2014 at 07:26:41PM +0100, Paolo Bonzini wrote: > > > On 10/11/2014 19:17, Michael S. Tsirkin wrote: > > > No, I mean can you do it also for pc-2.1 and earlier? Or should it be > > > only for the last machine type? > > > > I don't see why it should, it can't break migration. > >

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Paolo Bonzini
On 10/11/2014 19:17, Michael S. Tsirkin wrote: > > No, I mean can you do it also for pc-2.1 and earlier? Or should it be > > only for the last machine type? > > I don't see why it should, it can't break migration. > It changes the contents of the SRAT. There is a possibility that it triggers

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Michael S. Tsirkin
On Mon, Nov 10, 2014 at 06:56:30PM +0100, Paolo Bonzini wrote: > > > On 10/11/2014 18:48, Igor Mammedov wrote: > >> > Does this need to be specific to pc-2.2? > > Why not, It's bug fix. > > But I don't care if it's merged later. > > No, I mean can you do it also for pc-2.1 and earlier? Or shoul

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Paolo Bonzini
On 10/11/2014 18:48, Igor Mammedov wrote: >> > Does this need to be specific to pc-2.2? > Why not, It's bug fix. > But I don't care if it's merged later. No, I mean can you do it also for pc-2.1 and earlier? Or should it be only for the last machine type? Paolo

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Igor Mammedov
On Mon, 10 Nov 2014 18:40:12 +0100 Paolo Bonzini wrote: > > > On 10/11/2014 17:20, Igor Mammedov wrote: > > If QEMU is started with -numa ... Windows only notices that > > CPU has been hot-added but it will not online such CPUs. > > > > It's caused by the fact that possible CPUs are flagged a

Re: [Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Paolo Bonzini
On 10/11/2014 17:20, Igor Mammedov wrote: > If QEMU is started with -numa ... Windows only notices that > CPU has been hot-added but it will not online such CPUs. > > It's caused by the fact that possible CPUs are flagged as > not enabled in SRAT and Windows honoring that information > doesn't

[Qemu-devel] [PATCH for-2.2] pc: acpi: mark all possible CPUs as enabled in SRAT

2014-11-10 Thread Igor Mammedov
If QEMU is started with -numa ... Windows only notices that CPU has been hot-added but it will not online such CPUs. It's caused by the fact that possible CPUs are flagged as not enabled in SRAT and Windows honoring that information doesn't use corresponding CPU. ACPI 5.0 Spec regarding to flag