Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-18 Thread Michael S. Tsirkin
On Fri, Aug 18, 2017 at 05:00:18PM +0100, Anthony PERARD wrote: > > > > > > > > > > Clean it up after 2.10. > > > > > > > > > > > So is the v2 good enough or do I need to resend it? > > Do you really need it in 2.10? > > it's only 2 days left till release so unless it's blocker > > I'd wait ti

Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-18 Thread Michael S. Tsirkin
On Fri, Aug 18, 2017 at 04:19:57PM +0200, Igor Mammedov wrote: > > > > > > > > Clean it up after 2.10. > > > > > > > > So is the v2 good enough or do I need to resend it? > Do you really need it in 2.10? > it's only 2 days left till release so unless it's blocker > I'd wait till after release

Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-18 Thread Anthony PERARD
On Fri, Aug 18, 2017 at 04:19:57PM +0200, Igor Mammedov wrote: > On Fri, 18 Aug 2017 14:31:07 +0100 > Anthony PERARD wrote: > > > On Fri, Aug 18, 2017 at 11:37:34AM +0200, Igor Mammedov wrote: > > > On Fri, 18 Aug 2017 04:40:02 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu, Aug

Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-18 Thread Igor Mammedov
On Fri, 18 Aug 2017 14:31:07 +0100 Anthony PERARD wrote: > On Fri, Aug 18, 2017 at 11:37:34AM +0200, Igor Mammedov wrote: > > On Fri, 18 Aug 2017 04:40:02 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Aug 17, 2017 at 05:23:46PM +0100, Anthony PERARD wrote: > > > > This means that

Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-18 Thread Anthony PERARD
On Fri, Aug 18, 2017 at 11:37:34AM +0200, Igor Mammedov wrote: > On Fri, 18 Aug 2017 04:40:02 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Aug 17, 2017 at 05:23:46PM +0100, Anthony PERARD wrote: > > > This means that the function will be call and the property > > > acpi-pcihp-bsel will be se

Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-18 Thread Igor Mammedov
On Thu, 17 Aug 2017 17:23:46 +0100 Anthony PERARD wrote: > This means that the function will be call and the property > acpi-pcihp-bsel will be set even if ACPI build is disable. s/call/called/ s/disable/disabled/ Maybe something along this lines: HW part of APCI PCI hotplug in QEMU depends on

Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-18 Thread Igor Mammedov
On Fri, 18 Aug 2017 04:40:02 +0300 "Michael S. Tsirkin" wrote: > On Thu, Aug 17, 2017 at 05:23:46PM +0100, Anthony PERARD wrote: > > This means that the function will be call and the property > > acpi-pcihp-bsel will be set even if ACPI build is disable. > > > > To do PCI passthrough with Xen, t

Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-17 Thread Michael S. Tsirkin
On Thu, Aug 17, 2017 at 05:23:46PM +0100, Anthony PERARD wrote: > This means that the function will be call and the property > acpi-pcihp-bsel will be set even if ACPI build is disable. > > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > set, but this was done only when

[Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-17 Thread Anthony PERARD
This means that the function will be call and the property acpi-pcihp-bsel will be set even if ACPI build is disable. To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be set, but this was done only when ACPI tables are built which is not needed for a Xen guest. The need for th