Re: [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning

2017-07-21 Thread Peter Maydell
On 21 July 2017 at 13:23, Eric Blake wrote: > On 07/19/2017 03:19 AM, Peter Maydell wrote: >> On 18 July 2017 at 23:01, Eric Blake wrote: >>> On 07/18/2017 11:26 AM, Peter Maydell wrote: On OpenBSD the compiler warns: bsd-user/main.c:622:21: warning: variable 'sig' set but not used >>>

Re: [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning

2017-07-21 Thread Eric Blake
On 07/19/2017 03:19 AM, Peter Maydell wrote: > On 18 July 2017 at 23:01, Eric Blake wrote: >> On 07/18/2017 11:26 AM, Peter Maydell wrote: >>> On OpenBSD the compiler warns: >>> bsd-user/main.c:622:21: warning: variable 'sig' set but not used >>> [-Wunused-but-set-variable] >>> >>> This is becaus

Re: [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning

2017-07-21 Thread Thomas Huth
On 19.07.2017 10:19, Peter Maydell wrote: > On 18 July 2017 at 23:01, Eric Blake wrote: >> On 07/18/2017 11:26 AM, Peter Maydell wrote: >>> On OpenBSD the compiler warns: >>> bsd-user/main.c:622:21: warning: variable 'sig' set but not used >>> [-Wunused-but-set-variable] >>> >>> This is because a

Re: [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning

2017-07-19 Thread Peter Maydell
On 18 July 2017 at 23:01, Eric Blake wrote: > On 07/18/2017 11:26 AM, Peter Maydell wrote: >> On OpenBSD the compiler warns: >> bsd-user/main.c:622:21: warning: variable 'sig' set but not used >> [-Wunused-but-set-variable] >> >> This is because a lot of the signal delivery code is #if-0'd >> out

Re: [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning

2017-07-18 Thread Eric Blake
On 07/18/2017 11:26 AM, Peter Maydell wrote: > On OpenBSD the compiler warns: > bsd-user/main.c:622:21: warning: variable 'sig' set but not used > [-Wunused-but-set-variable] > > This is because a lot of the signal delivery code is #if-0'd > out as unused. Reshuffle #ifdefs a bit to silence the w

[Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning

2017-07-18 Thread Peter Maydell
On OpenBSD the compiler warns: bsd-user/main.c:622:21: warning: variable 'sig' set but not used [-Wunused-but-set-variable] This is because a lot of the signal delivery code is #if-0'd out as unused. Reshuffle #ifdefs a bit to silence the warning. Signed-off-by: Peter Maydell --- bsd-user/main